Find classes defined in the theme info file (eg skinr classes)

Well we could write a plugin for Skinr, that when a region is selected it would also be possible to select the class - that would be a win win - I'll try and test it out tomorrow!

Skinr integration would be swell, and if I am correct, Skinr only adds classes to the skinned items so integration should not be a huge issue.

As Swentel mentioned, we'll give it a spin today and keep you posted.

Skinr - Display Suite - Sweaver would be a very powerfull triangle in terms of theming!

Alright, first test revealed this: we already have a plugin for sweaver called 'Theme settings' - this simply displays the theme settings in a tab in sweaver. With skinr enabled, all those settings are available in that form, so that's nice. Note, saving isn't working right now and the form itself isn't nicely reachable, so don't test it yet.

I'm not sure what else we could write though, getting the interface in the tab for node types, views, blocks or comments seems like a complete overhead since there are a ton of options.

Thoughts ?

- edit -

The additional theme settings I saw where theme specific theme settings coming from the fusion core theme - those are saved.

Ok, we do have an idea for a Skinr plugin. We could try and find all styles/classes which are set in the interface and make them available on the tab. If you then select that style, you can change the properties in CSS. That would be a first rock!

Ok, the more I try and test, the less I'm not finding a good integration here. I need more inspiration and thoughts about integration because I don't see how right now - this is getting close to getting by design. The people of Skinr of course can write a plugin if they like :)

I should think before I write :)

We found a connection which possibly other themes can use also: we read the info file of the current theme and we'll try and find all classes defined in it. Clicking on them will trigger the style editor. In the backend there will be an option to select which groups can be found, to start with skinr.

renaming the title to reflect that plugin.

Alright, there is a new plugin called 'Theme classes' which finds the classes defined in the info file of a theme. So for example in fusion core, the group of 'skinr' has a couple of classes defined and that plugin will show them - when available on the page. Testen this also with acquia slate and skinr adding new classes on a block.

I'd say, give a spin run (on the next dev build). Other suggestions are welcome, but try to see it in the context of this plugin (and not necessarily skinr alone, which should/can be another plugin which possibly has a complete other functionality)

Just FYI, Team Skinr (substantially Jacine) has been at her out-of-country wedding this past week or so :)

Team Fusion has also been keeping an eye on this and will check things out ;)

@steph cool :) Thanks for the mention also in the Acquia podcast
@patcon there is an alpha release out, see http://drupal.org/node/861406

Hey swentel, I'm just checking out this module... looking really intriguing so far :) I can't seem to figure out how to activate this Skinr integration feature though. I don't have a "Theme classes" option on the Plugins page, but I do have a Theme Classes tab. On that, the Theme groups field says "skinr". Is that all that needs to be in there?

I've been playing around in the front end of the editor but I don't see anything related to skinr styles or names of classes I have defined or set on blocks I'm clicking on. I'm probably missing something silly but any pointers would be great....

@stephthegeek

It should work like this. That textarea box defines groups which the plugin itself will look for in the info file of the theme. So the 'skinr' default in that textarea box is probably the most common one used. At work we also have our classes in our themes - but not using skinr - so it's easy that way to add new groups.

; This is taken from the Fusion starter theme. The plugin will scan the skinr group here and find the 'fusion-example-stylename' class if it is used on the page.
; Note, all those classes are cached, so if you add new ones in your info file, make sure to go to the plugin page and submit the page so the cache is cleared on that one.

;skinr[fusion-example-styles][title] = Sample Skinr block styles
;skinr[fusion-example-styles][type] = checkboxes
;skinr[fusion-example-styles][features][] = block
;skinr[fusion-example-styles][options][1][label] = My sample Skinr style
;skinr[fusion-example-styles][options][1][class] = fusion-example-stylename

As soon as on a page one of those classes is found, it will show up in the tab on the frontend. So sometimes it might be empty. I'm still not sure if that's the way to go. It seems logical in my own head because if you don't see anything happening on your screen, you might really make some bad choices in the editor :)

Hope I'm clear enough.

Thanks for the help so far. I'm still not getting what is supposed to show up where. Attached is a screenshot of what I'm seeing.

So I've enabled Sweaver and Theme Classes, and "skinr" shows in the textarea. Then on a page on the site, I applied a couple of Skinr styles from the theme.

Am I missing a tab?

You're not missing a tab. We've committed some code since there was a small bug (and there seems to be another problem though), however, if you go to http://sweaver.customsource.be/ and login and switch to acquia slate, you should see what it actually does. However, acquia slate & sweaver don't seem to be working nicely yet, we have to check that.

Note: it's not related to acquia slate, we need to implements weights asap in our selectors, we'll integrate that normally this week somewhere!

@patcon, thanks for letting us know about the Skinr integration work being done here!

@sweaver, thanks for contributing your awesome module and we're looking forward to checking and testing the Skinr integration work you are doing. I haven't personally thought of the different ways the integration could be done, but so far it seems like you are on the right track and doing great work!

@swentel - This looks really awesome! I can't wait to try it out :)

@swentel -- ahh thanks for pointing to the demo site. It's clear what *should* be happening now. I haven't been able to get the styles to show up like that on my local test site, but it sounds like you're working on some related issues. Let me know if there's anything I can help with testing.

Also I'll point out that one of our themers is working on a module that will let you save Skinr styles through the UI: http://drupal.org/project/thimble
This could be an interesting point of connection for Sweaver/Skinr too, to use Sweaver's interface to build a skin and then save it for reuse.

We just need all of us together in a room somewhere with a lot of caffeine... :)

Working in beta release. If we can have more integration, please open another issue - but not with the title 'more integration with Skinr' and nothing in it :)