Fix performance of acl_node_clear_acls() [#852486]

acl_node_clear_acls() potentially loads a huge number of records instead of using a subquery.

This needs to be fixed.

We also need to look at the other functions for similar problems and then backport to D6.

Comment	File	Size	Author
#2	optimize-acl_node_clear_acls.852486.2.patch	778 bytes	salvis

Comments

good_man commented 2 March 2011 at 12:09

is limiting the similar queries (checking existence) to return only one row a one way to optimize it?

he/his

commented 31 March 2011 at 23:38

Status	File	Size
new	optimize-acl_node_clear_acls.852486.2.patch	778 bytes

It's not just about checking existence. The array is subsequently passed on to db_delete().

Could the attached patch work?

he/his

commented 1 April 2011 at 19:09

Status:

Active

» Needs review

he/his

commented 17 April 2011 at 20:41

Status:

Needs review

» Fixed

Committed in BETA3.

1 May 2011 at 20:41

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.