Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The node edit test currently fails with:
Node edit 91 passes, 2 fails, and 0 exceptions
This is because it does a:
$this->assertIdentical($node->uid, $this->admin_user->uid, 'Node authored by admin user.');
$node
comes from a node_load(), while $this->admin_user->uid comes from a db_insert().
To be 100% safe, SQLite should stringify all fetches (that will put it on par with PostgreSQL).
Comment | File | Size | Author |
---|---|---|---|
#1 | 851590-sqlite-stringify-fetches.patch | 1.22 KB | Damien Tournoud |
Comments
Comment #1
Damien Tournoud CreditAttribution: Damien Tournoud commentedFairly trivial patch. There was a needless cast to in
DatabaseConnection_sqlite::nextId()
and we addPDO::ATTR_STRINGIFY_FETCHES => TRUE
for consistency with PostgreSQL.Comment #2
Damien Tournoud CreditAttribution: Damien Tournoud commentedThis is a test failure on SQLite. Critical as a consequence.
Comment #3
Stevel CreditAttribution: Stevel commentedLooking good, and "93 passes, 0 fails, 0 exceptions" after applying this patch.
Comment #4
andypostTested, now test passed
Comment #5
Crell CreditAttribution: Crell commentedI may have to reference this patch on the PHP-DEV list if they are still insistent on having strict typing in PHP 5.next. Yeesh. (I'm +1 here.)
Comment #6
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. :)