netbabu [netbabu]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code, pointing out what it needs to be changed.

• The points reported in this review are not in order or importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1. The version line needs to be removed from the .info file.
2. License files cannot be committed in Drupal.org repository. Projects committed in Drupal.org repository have the same license used by Drupal.
3. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted.

4.   // Get active products
     $result = db_query("SELECT node.nid FROM {uc_products} INNER JOIN {node} ON uc_products.nid = node.nid WHERE node.status = 1");
     while ($node = db_fetch_object($result)) {
       $product = node_load($node->nid);
       
       //begin stock checking
       $stock = uc_stock_level($product->model );
       if($stock <= 0)
       {
         continue;
       }
       //end stock stocking
       
       // Grab terms for products
       $terms = array();
       foreach ($product->taxonomy as $term) {
         $ancestors = taxonomy_get_parents_all($term->tid);
         foreach ($ancestors as $ancestor) {
           $terms[] = $ancestor->name;
         }
       }
   
   			// Build kelkoo
   	$output .= "<Product>\n";
      // $output .= "<Category>" . check_plain($product->title) . "</Category>\n";
       $output .= "<Category>" . check_plain(implode(', ', $terms)) . "</Category>\n";
   	$output .= "<department>" . check_plain(implode(', ', $terms)) . "</department>\n";
       $output .= "<UniqueCode>" . htmlentities($product->model) . "</UniqueCode>\n";
   	$output .= "<Description>" . check_plain($product->body) . "</Description>\n";
       if (isset($product->field_image_cache) && file_exists($product->field_image_cache[0]['filepath']))
   	{
         $output .= "<image_link>" . $GLOBALS['base_url'] .'/'. ($product->field_image_cache[0]['filepath']) . "</image_link>\n"; 
       }
       $output .= "<LinkToProduct>" . $GLOBALS['base_url'] . '/node/' . $product->nid . "</LinkToProduct>\n";
       $output .= "<weight>" . $product->weight . ' ' . $product->weight_units . "</weight>\n";
       $output .= "<price>" . $product->sell_price . "</price>\n";
       $output .= "<product_type>" . check_plain(implode(',', $terms)) . "</product_type>\n";
   	
   	$output .= "<discount>" .check_plain($product->discount) . "</discount>\n";
   	//$output .= "<>" .check_plain(
   	
   
   

   The code is showing node data without to first verify if the user has access to the node. This is considered a security issue.
   The function to use to get a Drupal URL is url().

5. The module doesn't implement hook_uninstall().

I will review the code tomorrow.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.