Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sleeping_at-work-’s picture

Version: 6.x-2.0 » 6.x-2.x-dev
Status: Active » Needs review
FileSize
411 bytes

Would it be possible to include the ExplorerCanvas library through the Drupal Libraries API http://drupal.org/project/libraries ? This will bring all the advantages of the Libraries API. I'm adding a patch which needs to be tested.

sleeping_at-work-’s picture

I'm adding a new patch which is aimed just to support the Drupal Libraries API, without compromising the usability of the module for who's not implementing Libraries API in his system. It lacks testing.

kleinmp’s picture

Thanks for the patch!

I didn't know about the Drupal Libraries API, and it's a good idea. I'll test out the patch and commit it the next chance I get.

intyms’s picture

subscribing...

sleeping_at-work-’s picture

thanks :)

Anonymous’s picture

subshcribing.

kleinmp’s picture

Status: Needs review » Fixed

Committed to the dev version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

sleeping_at-work-’s picture

Status: Closed (fixed) » Needs review
FileSize
938 bytes

In order to grant consistency, please consider to review the README
Here's a patch

mrfelton’s picture

Status: Needs review » Needs work

This patch is not in the latest 2.x-dev branch.

mrfelton’s picture

Status: Needs work » Needs review
FileSize
1.77 KB

Here is a patch that reincorporates this fix as well as the update to the README.txt file into the latest 2.x-dev branch

SocialNicheGuru’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev

Will this be ported to D7?

acouch’s picture

Here is a D7 patch. This was necessary for us because we are trying to include this in a distro which makes it hard to package the excanvas library in the beautytips module and the "WARNING!" message is fired upon install which makes it look like the install was unsuccessful.

Only local images are allowed.

pifagor’s picture

Issue summary: View changes
Status: Needs review » Closed (outdated)
dharizza’s picture

Re-rolled patch to apply cleanly in latest dev version.