Closed (fixed)
Project:
Cufón
Version:
6.x-1.0-beta4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Jul 2010 at 13:18 UTC
Updated:
9 Nov 2010 at 10:00 UTC
GA cant track the outgoing links and website search, i would adapt the code found in http://drupal.org/node/356766 but there is a trouble cause by the version of the module , here is my js code:
// $Id: googleanalytics.js,v 1.3.2.10 2009/07/08 21:25:12 hass Exp $
$(document).ready(function() {
// Attach onclick event to document only and catch clicks on all elements.
$(document.body).click(function(event) {
// Catch only the first parent link of a clicked element.
$(event.target).parents("a:first,area:first").andSelf().filter("a,area").each(function() {
var ga = Drupal.settings.googleanalytics;
// Expression to check for absolute internal links.
var isInternal = new RegExp("^(https?):\/\/" + window.location.host, "i");
// Expression to check for special links like gotwo.module /go/* links.
var isInternalSpecial = new RegExp("(\/go\/.*)$", "i");
// Expression to check for download links.
var isDownload = new RegExp("\\.(" + ga.trackDownloadExtensions + ")$", "i");
try {
// Is the clicked URL internal?
if (isInternal.test(this.href)) {
// Is download tracking activated and the file extension configured for download tracking?
if (ga.trackDownload && isDownload.test(this.href)) {
// Download link clicked.
var extension = isDownload.exec(this.href);
pageTracker._trackEvent("Downloads", extension[1].toUpperCase(), this.href.replace(isInternal, ''));
}
else if (isInternalSpecial.test(this.href)) {
// Keep the internal URL for Google Analytics website overlay intact.
pageTracker._trackPageview(this.href.replace(isInternal, ''));
}
}
else {
if (ga.trackMailto && $(this).is("a[href^=mailto:],area[href^=mailto:]")) {
// Mailto link clicked.
pageTracker._trackEvent("Mails", "Click", this.href.substring(7));
}
else if (ga.trackOutgoing) {
// External link clicked.
pageTracker._trackEvent("Outgoing links", "Click", this.href);
}
}
} catch(err) {}
});
});
if (Drupal.jsEnabled) {
$(document).ready(function() {
Drupal.gaTrackerAttach(this);
});
}
firebug tel me : "there is missing } after function body
[Break on this error] }"
could you help me please ?
Comments
Comment #1
aiphesComment #2
hass commentedWhat the heck are you doing there and why? Outbound and search is trackable out of the box with the module.
Comment #3
aiphesi know but there is nothing in GA stats...so i've seen there was incompatibilties with some modules like jquery_update...and on one of my websites i had a problem with cufon that duplicated the GA code..so i'm searching why it doesnt work now..
Comment #4
hass commentedI'm not aware about issues with jquery update. Cufon must have a bug. File a bug over there.
Comment #5
aiphesComment #6
hass commented#734630: Cufon module disables $closure in preprocess_page function
Comment #7
aiphesfixed by update to Google Analytics 6.x-3.0