Consider altering the checkout form validation process

I believe Damien has done this, but we still need to implement the AJAX loading of the same page...

Let's decide if this needs to happen for RC1, too. We've survived so long without it that I'm not sure it's necessary...

Cross linking a duplicate issue: #1289014: Custom checkout pane custom form validation expects abnormal validation behavior

I've attached an update that'll pass the testbot (conflict with the recently committed patch to fix messages in checkout). I also brought back the submit handler to actually handle message restoring between page redirects and to set the redirect URL. This code came after an if check in the old handler that required validation to pass... so it was basically the actual submission part of the old submit handler.

The only thing I don't know is if you'd want me to clear the submit handlers at the end of the checkout form builder function like you do for the validate handlers. Interested to see what the test bost says. My local tests all worked great.

Just a note to say that I'm debugging those fails; as far as I can tell, they're related to the fact that making validation actually happen in a validation handler now means we have to accommodate AJAX posts which, in the case of the failing test, only includes an update to a country. If this is changed on the same page as an invalid e-mail address, we don't have the proper contents in the messages array in the form state for the pane.

Alrighty, what was happening was this code was replacing the stored messages array with rendered HTML at a time when that stored messages array would still need to be accessed again in a subsequent AJAX validation in which the previous errors are still present:

      // If there are messages in the session right now for this pane, theme
      // them into the form right above the pane itself.
      if (!empty($_SESSION['messages'])) {
        $form_state['storage']['messages'][$pane_id] = theme('status_messages');

        $form[$pane_id . '_messages'] = array(
          '#markup' =>  $form_state['storage']['messages']['messages'][$pane_id],
        );
      }

It could be we don't need to store the themed output in the form state or even that we could work some bypass into this during AJAX validation, but I'm trying to preserve the intent of the original patch by just putting the themed output in a separate 'themed_messages' array.

Also, I went ahead and set the form level #submit handlers like you did for #validate.

All clear, test bot and Damien bot?

#12: 842292-12.checkout_validate.patch queued for re-testing.

Test bot is out of disk space. Just as well since I had a typo. :-/

In case that fails provisioning again, this passed testing locally. If I don't hear any negative feedback, I'll commit this later today. It doesn't change any logic from your original patch that I can see and simply moves the submit handlery type stuff into a legit submit handler.

Commit: http://drupalcode.org/project/commerce.git/commitdiff/0e0beff