SVN Revisions Problem [#842198]

I believe that the patch submitted here http://drupal.org/node/750428#comment-2953852 creates a problem. My make file contains

projects[ucberkeley][type] = "profile"
projects[ucberkeley][download][type] = "svn"
projects[ucberkeley][download][username] = "bwood"
projects[ucberkeley][download][url] = "svn+ssh://svn.example.com/foo"

Running drush make -v I see:

Executing: svn --force --non-interactive 'export' ''                               [notice]
'svn+ssh://svn.example.com/foo'
'/tmp/drush_make_tmp_1277940359/__build__/profiles/ucberkeley' --username
'bwood' --password ''

The '' to the left of 'export' causes this command to fail (at least with my subversion 1.4 server). The fix is either to add

projects[ucberkeley][download][revision] = "HEAD"

or to apply my patch below. Setting $flags to null doesn't work. Maybe that should be fixed somewhere upstream. I'm assuming that if the user doesn't specify a revision, they want HEAD.

Comment	File	Size	Author
#4	drush-make-svn-rev_842198-3170346.patch	512 bytes	bwood
#1	drush-make-svn-rev_842198.patch	678 bytes	bwood
#1	drush-make-svn-rev-readme_842198.patch	571 bytes	bwood

Comments

Status	File	Size
new	drush-make-svn-rev-readme_842198.patch	571 bytes
new	drush-make-svn-rev_842198.patch	678 bytes

Comment #2

dmitrig01 commented 2 July 2010 at 03:05

Status:

Active

» Fixed

this was fixed in beta 8

Comment #3

bwood commented 6 July 2010 at 18:17

Hi Dimitri,

I shoulda checked my version more carefully. Just downloaded beta8 and I see that the revision issue is fixed, but there was still a tiny bug preventing it from working for me: Missing space before '--username'. I'm attaching a new patch.