Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Sometime in the distant past, the sitemap module logged accesses of the sitemap to watchdog. I do not see that behavior in the current build for D6.
I just see logs of the sitemap being regenerated and when it gets submitted.
Could that please get added back in? Or did I miss a check box somewhere and that is why I am not seeing access logged?
Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | xmlsitemap_engines.module.diff | 1.41 KB | mdlueck |
| #18 | xmlsitemap_engines.install.diff | 549 bytes | mdlueck |
| #18 | xmlsitemap_engines.admin_.inc_.diff | 882 bytes | mdlueck |
| #18 | xmlsitemap_engines.module.diff | 1.41 KB | mdlueck |
| #18 | xmlsitemap_engines.install.diff | 549 bytes | mdlueck |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedI started to mark this "won't fix" but changed my mind. The issue with adding a watchdog entry is one of interest in time spent doing that action. Version 2.0 is created to enhance performance for production systems and such things are too much fluff for little gain when things work. Am I correct in thinking that you want this feature as a debugging tool?
Comment #2
mdlueck CreditAttribution: mdlueck commentedI am interested in IF search engines come to fetch the sitemap, how frequently, and which ones are fetching it.
Since Yahoo has the 401 issue, interested if they are even bothering to fetch the sitemap... perhaps I can turn off Yahoo as a engine to ping, etc...
As is, I would need to go through the raw Apache logs. Would be handy to bring that logging back... I miss it.
Comment #3
Dave ReidThe module allows hook_exit() to run after sitemaps are displayed. If you use statistics.module you should see hits on sitemap.xml. Add in modules like browscap you can see which user agents/search engines are hitting the path.
Comment #4
mdlueck CreditAttribution: mdlueck commented@David: I follow as far as turning on Statistics.
How do I get a watchdog entry each time sitemap.xml is accessed?
Comment #5
Dave ReidYou would need to code it yourself. Drupal doesn't create watchdog messages any time any page, RSS feed or XML is accessed. You'd have to do it in hook_exit().
Comment #6
mdlueck CreditAttribution: mdlueck commentedNo, I am not going to custom code what used to be in this module! That is anti-progress. :-(
Please consider adding back in the form of a check box on the admin interface if sitemap accesses are to be logged, and when checked log accesses including refer info. That way those that are not interested can turn it off (should be the default value) and those that are interested can check / turn it on.
Comment #7
Dave ReidSorry it's not on my radar.
Comment #8
WeRockYourWeb.com CreditAttribution: WeRockYourWeb.com commentedToo bad. Also miss this feature.
Comment #9
mdlueck CreditAttribution: mdlueck commentedI quickly came up with this diff which appears to work with 6.x-2.0-beta1 version code and restores the functionality of logging accesses of sitemap.xml.
Please review the patch, cleanup as necessary, and consider merging back into the 2.x source tree. Thanks!
Comment #10
mdlueck CreditAttribution: mdlueck commentedI updated my patch for the beta2 release, and found I had overlooked to clean up the variable in the .install file, so added that diff to this beta2 patch. Please consider merging this back into the production version of this module.
Comment #11
Dave ReidNew features are applied to 7.x-2.x-dev and then backported to 6.x-2.x-dev. Please read the pages on creating patches - I cannot use .zip files for changes.
Comment #12
mdlueck CreditAttribution: mdlueck commented@David, I updated my patch for xmlsitemap-6.x-2.0-beta3 and will attach the files one-at-a-time here. I do not have git set up, which it sounds like that is needed for the instructions you linked to.
I will try to also provide a patch for your D7 version per your request.
Comment #13
mdlueck CreditAttribution: mdlueck commentedHere is the diff to make the xmlsitemap-7.x-2.0-beta3 mod work as the D6 version.
Thank you for checking this diff over and considering putting logging back in this mod.
Comment #14
mdlueck CreditAttribution: mdlueck commented@David, Any update on considering reintroducing this functionality to the module? I believe I accurately provided the patches you requested, so wondering what the next step is. Thanks.
Comment #15
mdlueck CreditAttribution: mdlueck commentedThe diff applies beautifully to rc1.
Would you please consider putting this capability back in to the official mod?
Comment #16
mdlueck CreditAttribution: mdlueck commentedBump...
The diff applies beautifully to rc2.
Would you please consider putting this capability back in to the official mod?
Comment #17
mdlueck CreditAttribution: mdlueck commentedBump...
The diff applies beautifully to the rc2 versions of the D6/D7 module versions.
Would you please consider putting this capability back in to the official mod?
Comment #18
mdlueck CreditAttribution: mdlueck commentedBump...
I redid my diff patch so that it would not complain that hunks had moved. Both D6 and D7 patches supplied.
May you please update as to the status of considering turning this capability back on in the official version.