Closed (fixed)
Project:
Filebrowser
Version:
6.x-2.0-rc12
Component:
Directory Listing Pages
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Jun 2010 at 10:15 UTC
Updated:
22 Nov 2010 at 19:28 UTC
Jump to comment: Most recent file
Comments
Comment #1
Carlos Miranda Levy commentedThanks!
This fixed the problem of the file list not being sorted by display name.
I confirm this change (display-name should be left unchanged everywhere else it appears) fixes this issue, at least with PHP 5.3 and filebrowser 2.0-rc12.
Thanks again, I spent 2 hours trying to figure out why sorting was not working for me.
Comment #2
Yoran commentedActually this is not enough to fix as this constant (line 47) is used in many place. Changing like that will fix the sort but break lot of stuff.
As the sorter design was definitely wrong, specially with new metadata API, I rewrote this part. It's commited in dev, tell me if this is ok for you when the tarball is ready.
Comment #3
Yoran commentedComment #4
dum3r commentedI've have same warning after updating from r10 to r12 and dev
warning: usort() expects parameter 2 to be a valid callback, no array or string given in /var/www/drupal-6.17/sites/all/modules/filebrowser/filebrowser.theme.inc on line 219.
warning: usort() expects parameter 2 to be a valid callback, no array or string given in /var/www/drupal-6.17/sites/all/modules/filebrowser/filebrowser.theme.inc on line 223.
Warning is gone only if i remove 'Display name', 'Description' from showed fields' list
Comment #5
glottus commentedTrying to use the dev version, but still getting the usort() warning if any sort argument is present, or if Display Name is used.
Since switching to dev, I also get "Parse error: parse error in ....\filebrowser.theme.inc(218) : runtime-created function on line 1" and the same for filebrowser.theme.inc(223).
Comment #6
tjharman commentedIs there a version of this module ATM at works?
The "release candidate" gives me errors, as does the development version.
Does anyone have a link to a stable working version?
Comment #7
bgilday commentedsubscribing
Comment #8
dum3r commentedmay be we should change status to 'active' from 'fixed'
Comment #9
greywolfsspirit commentedAlso getting this same error, running the dev version released Jul 11, 2010.
Parse error: parse error in C:\wamp\www\sites\all\modules\filebrowser\filebrowser.theme.inc(218) : runtime-created function on line 1
Parse error: parse error in C:\wamp\www\sites\all\modules\filebrowser\filebrowser.theme.inc(223) : runtime-created function on line 1
Comment #10
greywolfsspirit commentedAnother bug I spotted, is, if your filename or directory name has a Space or an & or a # sign, you have to manually edit the descript.ion file and put " " around the filename/directory name for it to show up in the metadata section. The filter is not allowing these to be displayed as is. I have many files that use an & in them and a lot with spaces as well. Can we get this looked into to allow files with these scenerios to not filter out these characters?
Comment #11
DruKaz commented@greywolfsspirit: it's better if you report that bug in a new issue. That way, it's easier for the developer to spot and to see what still needs to be done.
For the ones that want to revert to a previous (working) version:
I was lucky enough to have recently backed-up my entire site again. So I still have the dev-version of march 31 wich isn't affected by the bug.
Note: if you get an error after reverting to this version, run update.php again (wich you should actually always do)
Comment #12
greywolfsspirit commentedChecking to see if anyone has made progress on a patch to get this working correctly yet.
Comment #13
glottus commentedFor now, I'm using the previous version that DruKaz provided in #11. That's working for me.
Comment #14
ak commentedsubscribing
Comment #15
greywolfsspirit commentedJust checking to see if you had a chance to look into this, Yoran? Haven't seen any updates since Jul 11th, and with the issues, I've been forced to sit back and wait on someone to figure out a fix on this. Thanks. Currently using the dev copy posted in #11.
Comment #16
tlogan commentedsubscribing
Comment #17
hovemt commentedI made a patch on filebrowser.theme.inc on lines 201 and 205. It parses the name of the sort to a function, and if there is a dash in the name, which is there for display-name the function doesn't get called. I did put in a strtr to translate the dash into an underscore.
I don't know if I made the patch correctly, so let me know if it's not working.
Comment #18
Yoran commentedSorry I'm late :/ As this is a no so big module with not so many users, you can ping me by using contact form when your stuck like this ! The developer interface for this issue system is very difficult to follow if you don't open the issues page regularly.
Anyway this should be fixed in last dev version.
Comment #20
fess commentedThanks! very helpful!
Comment #21
jdelgama commentedAplied filebrowser.theme_.inc_.patch and it worked for me!
Thanks!