Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
First off, I can say that the module works really well. However, I can see some potential for it including Rules Integration. Why Rules integration when it has Actions and Triggers? Well, because I want to be able to say to someone that if they have more than one active session, but less than 2 that they may need to clear their cache or something like that. Then if they have more than 2 they are automatically logged off.
Comments
Comment #1
Leeteq CreditAttribution: Leeteq commentedSecond that, in particular now that the trigger module is thrown out of core, and being replaced with just Rules at some point in the future.
#764558: Remove Trigger module from core
#1413214: Provide upgrade path from Trigger to Rules
http://drupal.org/project/trigger
http://drupal.org/project/rules
Comment #2
Leeteq CreditAttribution: Leeteq commentedComment #3
Leeteq CreditAttribution: Leeteq commentedFYI - Parallel discussion in Autologout module, I refer to this issue in comment #11 there:
#925818: should the one session feature be removed from autologout?
Comment #4
bessone CreditAttribution: bessone commentedRules integration sounds really interesting, any update on that from the mantainer?
Comment #5
johnennew CreditAttribution: johnennew commentedPlease find a patch attached which directly replaces trigger with rules. There is no need to have a dependency on rules with this patch.
Comment #6
deekayen CreditAttribution: deekayen commentedWhy does adding Rules mean removing Trigger? Since Trigger is just a hook anyway, can't the module keep Trigger, add Rules, and drop the dependency on Trigger?
Comment #7
johnennew CreditAttribution: johnennew commentedYeah, no need to lose the trigger hooks - here's the patch, no external dependencies. I've moved the drupal_goto on collision as well as the unpredictability of the hook ordering means that the goto can fire before trigger or rules hooks have had a chance to do anything. I wonder if it can be removed entirely.
Comment #8
deekayen CreditAttribution: deekayen commentedAdded to 7.x-2.x in f4d1af9.
Comment #9
johnennew CreditAttribution: johnennew commentedbackport to 6.x-2.x attached
Comment #10
johnennew CreditAttribution: johnennew commentedchanging to needs review, over to you test bot ...
Comment #11
johnennew CreditAttribution: johnennew commentedCommitting to 6.x-2.x
Comment #12
johnennew CreditAttribution: johnennew commented