Rules Integration (shift away from Trigger dependency) [#837962]

First off, I can say that the module works really well. However, I can see some potential for it including Rules Integration. Why Rules integration when it has Actions and Triggers? Well, because I want to be able to say to someone that if they have more than one active session, but less than 2 that they may need to clear their cache or something like that. Then if they have more than 2 they are automatically logged off.

Comment	File	Size	Author
#9	session_limit-rules_integration-837962-7481712.patch	6.32 KB	johnennew
#9
#7	session_limit-rules_integration-837962-7470328.patch	5.42 KB	johnennew
#7
#5	session_limit-rules_integration-837962-6757922.patch	3.7 KB	johnennew
#5

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Leeteq CreditAttribution: Leeteq commented 7 October 2012 at 00:21

Title:

Rules Integration (shift away from Trigger dependency)

» Rules Integration

Second that, in particular now that the trigger module is thrown out of core, and being replaced with just Rules at some point in the future.

#764558: Remove Trigger module from core
#1413214: Provide upgrade path from Trigger to Rules
http://drupal.org/project/trigger
http://drupal.org/project/rules

Comment #2

Leeteq CreditAttribution: Leeteq commented 7 October 2012 at 00:17

Title:	Rules Integration	» Rules Integration (shift away from Trigger dependency)
Version:	6.x-2.1	» 7.x-2.x-dev
Component:	User interface	» Code
Category:	feature	» task
Priority:	Normal	» Major

Comment #3

Leeteq CreditAttribution: Leeteq commented 7 October 2012 at 01:21

Title:

Rules Integration

» Rules Integration (shift away from Trigger dependency)

FYI - Parallel discussion in Autologout module, I refer to this issue in comment #11 there:
#925818: should the one session feature be removed from autologout?

Comment #4

bessone CreditAttribution: bessone commented 21 November 2012 at 08:21

Rules integration sounds really interesting, any update on that from the mantainer?

Comment #5

johnennew CreditAttribution: johnennew commented 28 May 2013 at 21:49

Status:

Active

» Needs review

File	Size
session_limit-rules_integration-837962-6757922.patch	3.7 KB

Please find a patch attached which directly replaces trigger with rules. There is no need to have a dependency on rules with this patch.

Comment #6

deekayen CreditAttribution: deekayen commented 29 May 2013 at 00:33

Status:

Needs review

» Needs work

Why does adding Rules mean removing Trigger? Since Trigger is just a hook anyway, can't the module keep Trigger, add Rules, and drop the dependency on Trigger?

Comment #7

johnennew CreditAttribution: johnennew commented 29 May 2013 at 07:51

Status:

Needs work

» Needs review

File	Size
session_limit-rules_integration-837962-7470328.patch	5.42 KB

Yeah, no need to lose the trigger hooks - here's the patch, no external dependencies. I've moved the drupal_goto on collision as well as the unpredictability of the hook ordering means that the goto can fire before trigger or rules hooks have had a chance to do anything. I wonder if it can be removed entirely.