I was going nuts trying to figure out why my downloadable products where saying they needed to be shipped. Finally I discovered it was the the uc_wishlist module that caused it.

function uc_wishlist_cart_item() -> case 'can_ship': returns TRUE for all cases

This should be commented out // return TRUE;
uc_wishlist should not say whether items in cart are shippable or not. The cart does this by default.

This conflicts with uc_file, for downloadable products, which correctly alters the shippable state.

This is in uc_wishlist 6.x-1.1 and 6.x-1.x-dev

CommentFileSizeAuthor
#1 uc_wishlist-6.x-1.x-dev_canship.patch479 bytestinker
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tinker’s picture

tinker CreditAttribution: tinker commented
FileSize
uc_wishlist-6.x-1.x-dev_canship.patch479 bytes

This is still a problem in dev and stable release. I have attached a patch. Please can this fix be committed. Thanks

tinker’s picture

tinker CreditAttribution: tinker commented
Status: Active » Needs review

Super old one liner patch. Marked critical for ages because it messes with ever other module that checks if product is shippable. How about a commit?

  • Sagar Ramgade committed f2b9929 on 6.x-1.x 
    Issue #835594 by tinker: always sets cart items as shippable
Sagar Ramgade’s picture

Sagar Ramgade CreditAttribution: Sagar Ramgade commented
Issue summary: View changes
Status: Needs review » Fixed

Committed the patch with some modification Commit #f2b9929

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tinker’s picture

tinker CreditAttribution: tinker commented

Thx @sagar for the commit!