Closed (fixed)
Project:
Google News sitemap
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
19 Jun 2010 at 16:45 UTC
Updated:
30 Sep 2018 at 01:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jmbarlow commentedOops - forgot the code tags
Should be:
Ends up looking like this google news map from one of my clients, Gerard Associates.
Comment #2
kentr commented+1.
I'd like to see the patch.
I envision this as coming from a taxonomy vocabulary - perhaps there could be a configuration option to specify which vocabulary.
For keywords, see #748098: Keywords not being picked up?
Comment #3
drupalgideonAnd the access tag too, but not sure how this could be implemented. Perhaps check the value of a CCK field on a node or if the Premium or Node Option Premium module is installed and content is premium.
Perhaps the best way would be for a hook to be added so we can do our own additions (keywords, genre etc) before the sitemap output is generated.
Comment #4
koelneruwe commentedHi,
I am a little bit stupid about drupal (newbie). Where do I have to write the " $content .= 'PressRelease,OpEd,Opinion,Blog';
$content .= 'your keywords,comma separated';" ?
Thx for your help.
Uwe
Comment #5
greenreaperThis can be done simply if you only have one taxonomy to worry about - for example, categories/tags like 'reviews', 'opinions' and 'announcements' which indicate the genre for news sitemap purposes.
I'm throwing up what I hacked together in case people want to play with it. It also grabs a list of keywords but it does not do any filtering by vocabulary. The patch mentioned in #2 looks to be a more robust method of generating keywords.
This code will not work with D7 as it uses taxonomy_node_get_terms; it's probably trivial to fix, but I don't have it to test.
Comment #6
liquidcms commentedover a year old so figured i would hijack this thread...
as per original posting there are numerous tags missing from the xml.
bumping to D7, and from what i can see the following tags are missing:
- access
- geo_location
- genres
- stock_tickers
- keywords
would decent approach not simply be to add global admin fields for these and then support Tokens to fill?
in that way they could be token filled with terms from some vocab (keywords), access level or status text (access), possibly custom user created token for things like genres, static text for tickers
I will likely give this a shot; but please let me know if i am missing something like perhaps these are already implemented and i just haven't found the ui for it.
Comment #7
liquidcms commentedthis adds support for the additional added tags:
using the token method i mentioned above.
Comment #8
muqti commentedExcellent work mate. Was looking for it from a long long time. Just glad that someone stepped up.
Comment #9
damienmckennaThe patch in #7 is a great step in the right direction, this version is tidied up a bit, separates the list of tags into its own function that is wrapped in drupal_alter(), changes the 'access' tag to a selector, and adds variable_del() items to the uninstall script.
Comment #10
damienmckennaThe Genres tag should really be updated to use the list from http://support.google.com/news/publisher/bin/answer.py?hl=en&answer=93992.
Comment #11
damienmckennaThis is a reroll of #9 that adds a selector for the Genre tag and has other improvements, particularly around tag descriptions.
Comment #13
damienmckenna#11: googlenews-n832440-11.patch queued for re-testing.
Comment #14
damienmckennaCommitted, thanks for all the help everyone.
Comment #15
damienmckennaNeeds to be backported to D6.
Comment #16
damienmckennaComment #17
damienmckennaThe D6 version is no longer supported. Sorry folks.