The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.We should cleanup the module code.
Many callbacks can be moved into a separated file and would reduce complexity of the base file.
Also we should limit the code execution complexity for regular calls. Especially if advpoll isn't even involved.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | advpoll-cleanup-821044-6.patch | 145.96 KB | jacob.embree |
| #2 | advpoll-cleanup-821044-2.patch | 167.93 KB | jacob.embree |
Comments
Comment #1
miro_dietikerCommitted a first cleanup.
Moved things out of advpoll.module.
Created .pages.inc and .admin.inc files.
Seems to be well checked, everything still works as expected.
Needs more cleanup!
Comment #2
jacob.embree commentedFirst attempt here. Plenty more to do. Part of the coder review involved fixing #2407473: Choice form element key is not concatenated correctly.
Comment #3
ChrisKennedy commentedWhoops, ignore this comment - meant to post it to the tests issue.
Comment #4
ChrisKennedy commentedOk, actually trying this patch it looks like it doesn't apply cleanly to the codebase - appreciate the work here though. I'm getting hunk failures in advpoll.info, advpoll_field.info, and advpoll_ranking.info right now.
Comment #5
tripper54 commentedClosing this as most of this work has been done through other commits.
Comment #6
jacob.embree commentedHere is an updated patch. A lot was done, but there's a lot left.
Comment #8
tripper54 commentedGreat work, thanks for taking the time to do this.