based on aaron comment about Red/green color blindnessand its prevalence: about 10% of people, I think it's a good idea to change the colors.

I'm really bad for design :-p, if someone can help me with an image with the example widget I could make it real I think ;-)

Files: 
CommentFileSizeAuthor
#17 vote_up_down-816776.patch14.22 KBSoren Jones
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vote_up_down-816776_2.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]
#13 vote_up_down-816776.patch14.22 KBSoren Jones
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vote_up_down-816776_1.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]
#11 vote_up_down-816776.patch17.76 KBSoren Jones
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vote_up_down-816776_0.patch.
[ View ]
#11 arrows.png968 bytesSoren Jones
#11 plus.png262 bytesSoren Jones
#11 arrows.png1.83 KBSoren Jones
#6 vote_up_down-816776.patch8.92 KBSoren Jones
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vote_up_down-816776.patch.
[ View ]
#6 arrows.png835 bytesSoren Jones

Comments

marvil07’s picture

Title:better colors for plain widget» better colours for plain widget

upps

marvil07’s picture

Version:6.x-2.x-dev» 6.x-3.x-dev
Issue tags:+Needs color accessibility review
Soren Jones’s picture

IMHO, the colors aren't an accessibility issue.
One arrow pointing right that was either green or red would be an issue.
Although red and green do have meaning for many people who can distinguish between the two colors, with an up and down arrow, the colors really aren't functional, they're decorative.

However, as you think it's a good idea to change the colors, for maximum aesthetic compatibility with a variety of themes, maybe both arrows should be the same neutral color (e.g. black).

marvil07’s picture

Title:better colours for plain widget» better colours for plain and upanddow widgets

When I was working on #811694: New widget for splitting of votes in positives/negatives (5 voted up, 2 voted down) and I was deciding with the help of two designers about how the widget should look like, they suggest me the same, use one color for the two arrows.

Anyway, finally I end up using two colors, so this also make sense for the upanddown widget.

marvil07’s picture

Title:better colours for plain and upanddow widgets» better colours for plain and upanddown widgets
Soren Jones’s picture

Status:Active» Needs review
StatusFileSize
new835 bytes
new8.92 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vote_up_down-816776.patch.
[ View ]

Something to get you started.

marvil07’s picture

Title:better colours for plain and upanddown widgets» better colours for plain, altrenate and upanddown widgets

I like how this looks like in black/white colours.

Thanks for the patch!

Actually I remember alternate widget also uses colours, so adding it to the list.

marvil07’s picture

Title:better colours for plain, altrenate and upanddown widgets» better colours for plain, alternate and upanddown widgets

upps

AntiNSA’s picture

I really dont like the red and green too. In China, red meants positive. Look at the symbol for the Chinese stock market.

I think black and white in a box would be cleaner.

Status:Needs review» Needs work

The last submitted patch, vote_up_down-816776.patch, failed testing.

Soren Jones’s picture

Status:Needs work» Needs review
StatusFileSize
new1.83 KB
new262 bytes
new968 bytes
new17.76 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vote_up_down-816776_0.patch.
[ View ]

Synching with HEAD and adding grayscale images for alternate and upanddown widgets.

Status:Needs review» Needs work

The last submitted patch, vote_up_down-816776.patch, failed testing.

Soren Jones’s picture

Status:Needs work» Needs review
StatusFileSize
new14.22 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vote_up_down-816776_1.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

See #11 for the png files.

Status:Needs review» Needs work

The last submitted patch, vote_up_down-816776.patch, failed testing.

madjr’s picture

sub

Soren Jones’s picture

Status:Needs work» Needs review

#13: vote_up_down-816776.patch queued for re-testing.

Soren Jones’s picture

StatusFileSize
new14.22 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vote_up_down-816776_2.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

Same patch.

marvil07’s picture

Status:Needs review» Fixed

@Soren Jones: sorry for the big delay and huge thanks for the patches :-)

I just make a little change on plain arrows to avoid that they look in a continuous figure.

So, patch committed to 3.x.

Soren Jones’s picture

No worries. (^^)v And thanks for the review and the fix. \(^^)/

Status:Fixed» Closed (fixed)
Issue tags:-accessibility, -Needs color accessibility review

Automatically closed -- issue fixed for 2 weeks with no activity.