Your style plugin class looks nearly the same then the default table class.

If you extend views_plugin_style_table you could save quite a amount of code.

Comments

rooby’s picture

rooby commented

I considered this before and during making this module and I actually had it that way at the start but I was a bit torn.

I had a couple of reasons why I thought it might be better to do it this way but since having another look now (and more sleep) and writing them here I don't think they are so valid (plus I found a bit of a bug :))

So yeah, even though it will mostly be overridden I agree it will be better that way.
It also make more sense.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Fixed

ok, if you think so.

rooby’s picture

rooby commented
Assigned: Unassigned » rooby
Status: Fixed » Active

Sorry, sometimes I'm a little unclear with my posts.

What my reply was meant to say it that I agree with you and I will be changing it when I get a chance.

dawehner’s picture

dawehner
Primary language German
commented

Ah ok. Thats fine :)

rooby’s picture

rooby commented
Status: Active » Fixed

I have changed this now in dev.

http://drupal.org/cvs?commit=402670

rooby’s picture

rooby commented

Oops, now it's committed to the 6 branch.
http://drupal.org/cvs?commit=402732

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.