#810176: Search result titles should be enclosed in a heading tag. landed and so I was looking over how Bartik's search result page looks. Becuase we put a lot of spacing below paragraphs, I think individual search results need some separation... so, here is a patch ... and here is a screenshot

CommentFileSizeAuthor
#13 811898-before.png217.72 KBtim.plunkett
#13 811898-after.png213 KBtim.plunkett
#12 search-results-padding-border-v2.patch1007 bytesmason@thecodingdesigner.com
#10 search-results-padding-border.patch890 bytesmason@thecodingdesigner.com
#5 bartik-search-result-v1.patch825 bytesJeff Burnz
#3 bartik-search-ol.png24.74 KBJeff Burnz
search-results.patch830 bytesbleen

Comments

bleen’s picture

bleen commented

Blaaaarg ... wrong screenshot.
Only local images are allowed.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
Jeff Burnz’s picture

Jeff Burnz commented
StatusFileSize
new bartik-search-ol.png24.74 KB

Do we really want all that padding for search results?

aspilicious’s picture

aspilicious commented
Status: Reviewed & tested by the community » Needs review

No we don't want that ;) (my opinion)

Jeff Burnz’s picture

Jeff Burnz commented
StatusFileSize
new bartik-search-result-v1.patch825 bytes

Just updating bleens patch, removes padding from the OL.

jensimmons’s picture

jensimmons commented

Here's what the search result page looks like now, with no patch applied:

Only local images are allowed.

jensimmons’s picture

jensimmons commented
Title: add border between search results » Improve look of search result page
Project: Bartik » Drupal core
Version: 7.x-1.x-dev » 7.x-dev
Component: Look and Feel » Bartik theme
Category: bug » task
Jeff Burnz’s picture

Jeff Burnz commented

#5: bartik-search-result-v1.patch queued for re-testing.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Needs review » Needs work

Clearly the patch will fail re testing so I wont bother, however this really needs work, search results could look better.

mason@thecodingdesigner.com’s picture

mason@thecodingdesigner.com commented
Status: Needs work » Needs review
StatusFileSize
new search-results-padding-border.patch890 bytes

I styled the search results a bit. not the left padding has been removed, and I've added a 1px border between listings.

Status: Needs review » Needs work

The last submitted patch, search-results-padding-border.patch, failed testing.

mason@thecodingdesigner.com’s picture

mason@thecodingdesigner.com commented
Status: Needs work » Needs review
StatusFileSize
new search-results-padding-border-v2.patch1007 bytes

cleaned up the code, rolling a new patch

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 811898-after.png213 KB
new 811898-before.png217.72 KB

This is exactly what we needed. Jen signs off on it. Awesome!
Here are screenshots:

BEFORE

AFTER

bleen’s picture

bleen commented

RTBC++ ... so much more betterer

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice improvement.

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.