menu_rebuild() sometimes produces

WD php: Notice: Undefined index:  module in _menu_router_build()        [notice]
(line 3194 of

The empty string default is filled in afterwards, no attempt is made to set it before then, so we just need to move it a bit earlier. I'm not sure what specifically causes this bug to occur, but it's a trivial fix.

Files: 
CommentFileSizeAuthor
#4 drupal-6.x-1288098366.patch568 byteshswong3i
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-6.x-1288098366.patch. View
menu_notice.patch801 bytescatch
PASSED: [[SimpleTest]]: [MySQL] 20,469 pass(es). View

Comments

chx’s picture

Status: Needs review » Reviewed & tested by the community

Still applies.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hswong3i’s picture

Version: 7.x-dev » 6.x-dev
Status: Closed (fixed) » Patch (to be ported)
Issue tags: +PHP 5.3 compatibility
FileSize
568 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch drupal-6.x-1288098366.patch. View

Case similar and also apply for Drupal 6.19. When "drush up" + PHP5.3.2 error message as below:

WD php: Notice: Undefined index: module in _menu_router_build() (line 2437 of includes/menu.inc).

Patch via drupal-6.x-dev CVS.

yched’s picture

Status: Patch (to be ported) » Reviewed & tested by the community

I'm bitten by this as well on D6 - no need for PHP 5.3, just enable a module that *adds* menu items in hook_menu_alter().

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drupal-6.x-1288098366.patch, failed testing.

joshuajabbour’s picture

Status: Needs work » Reviewed & tested by the community

despite the bot, this patch applies and fixes the issue. please apply to d6...

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)
Issue tags: -PHP 5.3 compatibility

Automatically closed -- issue fixed for 2 weeks with no activity.