Right or wrong?
IMO this doesn't belong under 'Logs'...
(enable statistics.module to see this happen)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ChrisKennedy’s picture

Version: x.y.z » 5.x-dev
Component: base system » statistics.module
Status: Active » Needs review
FileSize
1.57 KB

Agreed, patch attached.

forngren’s picture

Status: Needs review » Needs work
FileSize
7.53 KB

This patch breaks the alphabetical order of menu items for me, see attached screenshot. +1 for the concept

ChrisKennedy’s picture

Status: Needs work » Needs review
FileSize
1.84 KB

Ah true, I needed to remove the weight from the menu item, which was causing it to be at the end of lists.

Steven’s picture

I'm not sure I agree. Comment settings are in the comments section too.

ChrisKennedy’s picture

Perhaps the comment settings page should be moved too, but it makes more sense in that case because it's a tab rather than a basic menu item. I would prefer to stick to statistics in this issue though.

One of the best usability improvements in 5.0 imo is the reorganization of admin into sections. We should default to using the appropriate categories unless there is a good reason not to. In the case of the statistics settings I don't see a compelling reason to diverge from the standard location.

geodaniel’s picture

I'd add a +1 for this. I was just trying to set up statistics, and the settings weren't under 'site configuration' where I had initially looked. It took me a while to spot them under 'logs'.

ica’s picture

also there is a confusion here for 'not brainy' ones like myself :)
you can not see statics on the settings + statics actually called 'logs' logs are synonymous to stats but 'statistics' is more generic naming and suits better -imo no need for confusion -unless i am getting all wrong here and actually statistics and logs are entirely different things :)

also if you install Xstatistics.module as an extention to your statistics (logs) and activate the its block and your statistics not activated it'll give u a link -plase activate your statistics and link to
> /admin/settings/statistics

well thats where the Xstatistics.module developer thought it should be!! but its not there of course, instead its here
> admin/logs/settings

imho - the url dir. pattern should not break (without url redirect fix)
and logs should be under statistics - to give to other stat options more than logs

> admin/settings/statistics/logs

and listed under general settings page

-just some thought maybe there are more important reasons for to keep current way and there is a reason for not to do so as above

thanks

drumm’s picture

Version: 5.x-dev » 6.x-dev
Status: Needs review » Needs work

I think we should leave the menu rearrangements to the development versions of Drupal, currently 6.x.

Pasqualle’s picture

Title: Move 'admin/logs/settings' => 'site configuration' » Move 'admin/reports/settings' => 'site configuration'
Version: 6.x-dev » 7.x-dev

I think, this will not make it into drupal 6

lilou’s picture

Component: statistics.module » dblog.module
Category: bug » task

Make sense.

lilou’s picture

Component: dblog.module » statistics.module
Category: task » bug
swentel’s picture

Status: Needs work » Needs review
FileSize
1.22 KB
dawehner’s picture

it makes total sense for me
i had this problem many times to find this setting

i runned the tests of the statistic module:
36 passes, 0 fails, and 0 exceptions

anyone else?

Pasqualle’s picture

Status: Needs review » Reviewed & tested by the community

code looks good

webchick’s picture

FileSize
18.16 KB

"Access log settings" looks out of place with the other items here. See screenshot.

And probably, I would look for this under "Statistics," not "Access log" since I enabled the "Statistics" module?

webchick’s picture

Status: Reviewed & tested by the community » Needs work
Dave Reid’s picture

Status: Needs work » Needs review
FileSize
9.47 KB

+1 to "Statistics" settings since it is the name of the module. This menu item location has always irked me in D5/6. Attached patch fixes all the references to admin/reports/settings that were missed before and adds a much needed 'administer statistics' permission for the moved admin/settings/statistics.

Status: Needs review » Needs work

The last submitted patch failed testing.

Dave Reid’s picture

Status: Needs work » Needs review

Testing #17 and it installs and works for me. Setting back to code needs review for re-testing.

Dave Reid’s picture

Assigned: Unassigned » Dave Reid
Issue tags: +Usability
Dries’s picture

Status: Needs review » Fixed

Committed to CVS HEAD. Thanks!

Xano’s picture

What about moving the statistics out of the admin pages, so site administrators may decide to make them public using permissions? A lot of sites, however not the majority, have made their statistics publicly available.

Dave Reid’s picture

An interesting idea, but needs a separate issue. :)

Xano’s picture

Status: Fixed » Closed (fixed)
Issue tags: -Usability

Automatically closed -- issue fixed for 2 weeks with no activity.