The actual behaviour show a pop-up(that we need to move to a modal div using ctools: #807928: Use modal div instead of popup at denying vote), but IMHO it's better to let choose the behaviour,

To be clear, the two behaviours I have in mind are:

- hide the voting links(default)
- show the voting links, but show a deny message

Files: 
CommentFileSizeAuthor
#3 0001-task-807934-by-marvil07-Let-choose-vud-node-view-beh.patch6.88 KBmarvil07
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 0001-task-807934-by-marvil07-Let-choose-vud-node-view-beh.patch.
[ View ]

Comments

marvil07’s picture

Assigned:Unassigned» marvil07

There was an error in:

- hide the voting links(default)
- show the voting links, but show a deny message

The two behaviours should be:
- hide the voting widget(default)
- show the voting widget, but show a deny message on clicking at its voting links

I'll start working on this, but this is going to be dependent on the patch already rolled on #807928: Use modal div instead of popup at denying vote

marvil07’s picture

Assigned:marvil07» Unassigned

let's work on test before #812896: make tests work again!

marvil07’s picture

Status:Active» Needs review
StatusFileSize
new6.88 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 0001-task-807934-by-marvil07-Let-choose-vud-node-view-beh.patch.
[ View ]

Here a patch which depends on #807928: Use modal div instead of popup at denying vote.

Now, you can choose if you want to use the modal div or to avoid showing the voting links.

Status:Needs review» Needs work

The last submitted patch, 0001-task-807934-by-marvil07-Let-choose-vud-node-view-beh.patch, failed testing.

marvil07’s picture

Status:Needs work» Fixed

I'm commiting this, so we can have a beta1 in the next hour ;-)

Status:Fixed» Closed (fixed)
Issue tags:-vud-2-blocker

Automatically closed -- issue fixed for 2 weeks with no activity.