For better usage of tweets in Views I wrote a patch to integrate the module to Date API, so we can use the tweet's created time, the twitter account's created time and last refresh time as date arguments and filters.

CommentFileSizeAuthor
#15 twitter-807634-date_api-15.patch1.16 KBdgeo
#10 twitter-n807634-10.patch1.36 KBdamienmckenna
#4 twitter-7.x-5.x-date_api-807634.patch1.12 KBdgeo
twitter-dateapi-integration.patch1.01 KBderhasi

Comments

matt v.’s picture

matt v. commented

The patch applied cleanly to the 6.x-3.0-beta4 version for me and worked as described. I haven't tried applying it to the 6.x-3.x-dev version though.

13rac1’s picture

13rac1 commented
Version: 6.x-3.x-dev » 6.x-5.x-dev
Status: Needs review » Needs work

Patch does not apply, plus I'm sure this needs work since it was created for 6.x-3.x.

 $ git apply twitter-dateapi-integration.patch 
error: patch failed: twitter.module:251
error: twitter.module: patch does not apply
xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Version: 6.x-5.x-dev » 7.x-5.x-dev
Issue summary: View changes
Status: Needs work » Patch (to be ported)

Updated patch welcome, this would be a good addition if not already implemented.

dgeo’s picture

dgeo commented
StatusFileSize
new twitter-7.x-5.x-date_api-807634.patch1.12 KB

Here is an updated patch to 7.x-5.x current git.

It's the same plus date_api listed as dependency (needed ?)

dgeo’s picture

dgeo commented
Status: Patch (to be ported) » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: derhasi » Unassigned
Status: Needs review » Needs work

Triggering the testbot.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review

Triggering the testbot.

The last submitted patch, twitter-dateapi-integration.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: twitter-7.x-5.x-date_api-807634.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new twitter-n807634-10.patch1.36 KB

Rerolled. I also commented out the dependency - I don't think the module should require the Date module, but definitely benefit when it's available.

dgeo’s picture

dgeo commented

Seems to work here (on today's 7.x-5.x-dev :)

dgeo’s picture

dgeo commented

DamienMcKenna queued 10: twitter-n807634-10.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 10: twitter-n807634-10.patch, failed testing.

dgeo’s picture

dgeo commented
Status: Needs work » Needs review
StatusFileSize
new twitter-807634-date_api-15.patch1.16 KB
dgeo’s picture

dgeo commented

working on 3 different sites since 4 years…