Closed (fixed)
Project:
Bartik
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 May 2010 at 13:46 UTC
Updated:
6 Jun 2010 at 15:30 UTC
I promised jensimmons a review this weekend while we were at DrupalCamp Copenhagen, so here it is.
I've highlighted *some* of the changes I've made. Its *only* spacing, indentation and comment style fixes.
+++ themes/bartik/color/preview.js
@@ -0,0 +1,35 @@
+ // Text preview
Missing punctuation for some inline comments.
+++ themes/bartik/color/preview.css
@@ -0,0 +1,68 @@
+/**
+ * From color.css
+ */
Removed PHP style comments to be more consistent with the new CSS style comments.
+++ themes/bartik/color/preview.js
@@ -0,0 +1,35 @@
+ // Text preview
Missing punctuation for some inline comments.
+++ themes/bartik/css/layout.css
@@ -0,0 +1,68 @@
+#footer {
+ width: 960px;
+ margin-left: auto;
+ margin-right: auto;
+}
Fixed some spacing after selectors.
+++ themes/bartik/css/style-rtl.css
@@ -0,0 +1,236 @@
+.tabs ul.primary li {
+ margin: 0 0 0 5px;
+ float: right;
+ zoom: 1;
+}
Fixed some indentation issues.
+++ themes/bartik/css/style.css
@@ -0,0 +1,1270 @@
+table {
+ font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
+}
+
+input,
+textarea,
+select,
+a.button {
+ font-family: "Lucida Grande", "Lucida Sans Unicode", Verdana, sans-serif;
+}
Removed some blank lines between selector blocks.
| Comment | File | Size | Author |
|---|---|---|---|
| bartik-spacing-comments-1.patch | 8.8 KB | dixon_ |
Comments
Comment #1
jensimmons commentedThis should go in before anything else (so it doesn't have to rerolled), and it needs to go in before Bartik goes into core. (I gotta run, but I'll come back to it later.)
Comment #2
jensimmons commentedcommitted