It would be helpful to either let people know the maximum number of levels is (which is currently 10) and/or to update the tagadelic.css to include more levels.

CommentFileSizeAuthor
#3 tagadelic.module_806622.patch852 bytesvegantriathlete
#3 tagadelic.css_806622.patch462 bytesvegantriathlete

Comments

Bèr Kessels’s picture

Bèr Kessels commented

yes. That would be nice.
It would also be nice if someone did that. :)

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented

I'll see if I can make the time to roll a patch. What would you like me to roll the patch against?

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented
Status: Active » Needs review
StatusFileSize
new tagadelic.css_806622.patch462 bytes
new tagadelic.module_806622.patch852 bytes

I set the maximum number of levels to 16.

I used the diff command to create a patch for tagadelic.module and another patch for tagadelic.css. I ran them against the latest 1.x-dev version. Sorry for creating two separate patches. I don't know how to roll them into one with diff and I didn't want to go through the headache of dealing with CVS; I don't have a CVS environment set up for D6 and I don't like getting the CVS stuff in my D6 development environment.

If there is another way you would like me to do this, I would appreciate a bit of mentoring on how to go about it better. This is why I just filed the request initially without rolling a patch.

vegantriathlete’s picture

vegantriathlete
he/him/his
Primary language English
Location Lakewood, CO
commented
Component: Documentation » Code

The patches in #3 change both the code and the css. Maybe this has been sitting around since June because I had it categorized under Documentation instead of code?

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs review » Needs work

The patch could be very simple: just a small change in the sentence. Please do not make it more complex by introducing new features in a patch that aims to fix a tiny documentation error. from 10->16 levels is a new feature and should be discussed in a feature request on its own (but note, that I doubt there is any chance that will get in).

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs work » Closed (won't fix)