Checking an item off the list doesn't make it permanent

Yes, checking the boxes should be permanent...
Subscribing

This is absolutely a bug. Please apply attaching patch.

oliverhuynh, how did you create the patch? Please read http://drupal.org/node/707484.

The attached patch works.

Sorry. I made with other patch app. This needs review. I tested it ok.

Patch #3 does not work here.

Priority from Normal to Critical because if "Checking an item off the list doesn't make it permanent", what is the point of this module?

Pomliane, why you say that the patch does not work here? It's a one liner and it's necessary that we put the content of node_load($nid) in a variable. In this case $node = node_load($nid);

@yannickoo, the patch does not solve anything here: checking an item off the list still doesn't make it permanent.

It seems $nid is not defined in todo_filter_toggle() and, as a consequence, a new dummy node is created each time the function is called.
With a static $nid value in todo_filter_toggle(), the target node is saved but todo items states are not saved either...

@Pomliane, my patch was the "fix" for comment #2.

This is fixed in 6.x-1.0 and 7.x-1.0.

Hi,

this still isn't fixed for me:
I'm using the latest 6.x-1.0 version and firebug is giving me a 403 - forbidden error each time i try to check or uncheck an item.

Any ideas?

Does the user you are logged in as have permission to edit the node?

It also looks like the user you are logged in as has to have the ability to use the filter type selected for the body of the node.

sweenyy was the solution I posted correct? Can I mark this issue as resolved?

Closing since there is no response and todo is working as designed

I'm sorry but this doesn't work for me at all. I've tried both 7.x-1.0 and 7.x-1.x-dev and neither are doing an ajax save node when a todo list item is checked or unchecked. I've checked node access and edit permissions and even tried allowing all anon and authenticated users full edit rights, but it made no difference.

There are no js errors.

I have also just tested todo filter 7.x-1.x-dev on a totally clean install of the latest Drupal core 7.23 and am experiencing the same issue, so it's unlikely to be a module conflict. Just to be sure I also tried changing the todo filter ordering, but that didn't work either.

If you are using Chrome or Firefox, can you look at the Network tab in the inspect tool and see what the response is when you check an item on/off?

Doesn't look like it's using the full path to my Drupal instance.

404 Not Found
Request URL:http://localhost/todo/toggle/body[0]-1-2  

Ah, looks like the JavaScript is using a fixed path, not a relative one.
Drupal.settings.basePath needs to be added to the JavaScript file.

For Drupal 7, in the file todo_filter.js
Change this

$.post('/todo/toggle/' + $(this).attr('rel'));

To this

$.post(Drupal.settings.basePath + 'todo/toggle/' + $(this).attr('rel'));

I need to double check if D6 has this JS variable or not.

Works great, thanks zanix.

Great, I will get this added to dev soon

hook_node_view_alter() is only called when nodes are fully rendered. Notably, it isn't called when fields are displayed in Views or Panels. Switching to hook_field_attach_view_alter() fixes this. The attached patch also implements the change to the js suggested in #20.

Good catch, I didn't think about having to check Panels or views.

Commit d556240 on 7.x-1.x
Commit c3fc15b on 6.x-1.x