Hi there,

I noticed today that you wrote your captcha_requirements() function in your .module file. This works, but a great and easy optimization is to move it to the .install where it belongs (even if you only do something on the runtime phase.)

So just copying and pasting the function & docs from the .module to the .install will do.

Thank you.
Alexis Wilke

CommentFileSizeAuthor
#4 800846a.patch2.02 KBmarty
#1 800846.patch2.09 KBmarty

Comments

marty’s picture

marty commented
StatusFileSize
new 800846.patch2.09 KB

I've attached a patch for this.

soxofaan’s picture

soxofaan commented
Status: Active » Needs review

Great,
You also have to set the status to "needs review", to indicate that there is something to review, the automatic testing infrastructure will also kick in

Status: Needs review » Needs work

The last submitted patch, 800846.patch, failed testing.

marty’s picture

marty commented
Status: Needs work » Needs review
StatusFileSize
new 800846a.patch2.02 KB

Ok I've updated the patch - sorry about that it was the windoz line endings that messed things up.

AlexisWilke’s picture

AlexisWilke commented
Status: Needs review » Reviewed & tested by the community

Marty,

Get yourself a real OS! 8-) I suggest Linux...

Thank you for the patch!
Alexis

soxofaan’s picture

soxofaan commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)
Issue tags: +Needs tests, +low-hanging fruit

fixed for CAPTCHA 6.x-2.x by http://drupal.org/cvs?commit=374234
thanks marty!

To be ported to CAPTCHA 7.x-1.x and having tests for the wrong captcha counter would also be nice

soxofaan’s picture

soxofaan commented
Status: Patch (to be ported) » Fixed

committed to d7 version too: http://drupal.org/cvs?commit=387978

AlexisWilke’s picture

AlexisWilke commented

Thank you 8-)

Status: Fixed » Closed (fixed)
Issue tags: -Needs tests, -low-hanging fruit

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Needs tests, +low-hanging fruit

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.