No index on {semaphore}.value

Oh. We don't have an index on {semaphore}.value... that's a weird oversight.

Requalifying as a bug and bumping to D7.

Drupal7

  $schema['semaphore'] = array(
    'description' => 'Table for holding semaphores, locks, flags, etc. that cannot be stored as Drupal variables since they must not be cached.',
    'fields' => array(
      'name' => array(
        'description' => 'Primary Key: Unique name.',
        'type' => 'varchar',
        'length' => 255,
        'not null' => TRUE,
        'default' => ''
      ),
      'value' => array(
        'description' => 'A value for the semaphore.',
        'type' => 'varchar',
        'length' => 255,
        'not null' => TRUE,
        'default' => ''
      ),
      'expire' => array(
        'description' => 'A Unix timestamp with microseconds indicating when the semaphore should expire.',
        'type' => 'float',
        'size' => 'big',
        'not null' => TRUE
      ),
    ),
    'indexes' => array('value' => array('value')),
    'primary key' => array('name'),
  );

Drupal6

  $schema['semaphore'] = array(
    'description' => 'Table for holding semaphores, locks, flags, etc. that cannot be stored as Drupal variables since they must not be cached.',
    'fields' => array(
      'name' => array(
        'description' => 'Primary Key: Unique name.',
        'type' => 'varchar',
        'length' => 255,
        'not null' => TRUE,
        'default' => ''),
      'value' => array(
        'description' => 'A value.',
        'type' => 'varchar',
        'length' => 255,
        'not null' => TRUE,
        'default' => ''),
      'expire' => array(
        'description' => 'A Unix timestamp with microseconds indicating when the semaphore should expire.',
        'type' => 'float',
        'size' => 'big',
        'not null' => TRUE),
      ),
    'indexes' => array('expire' => array('expire')),
    'primary key' => array('name'),
    );

I think we would have to add expire to d7 and value to d6, right?

Adding expire index to d7.

Hmmm

#3: semaphore-missing-index.patch queued for re-testing.

#3: semaphore-missing-index.patch queued for re-testing.

Bumping to major, and I am happy with #3.

Committed to CVS HEAD. Moving this to the HEAD to HEAD project.

This needs to go to Drupal 6.

Please create new issues for head2head.

I created #863662: Add index on {semaphore}.expire

Yes, please stop moving core issues to HEAD2HEAD and create new issues instead. That makes things impossible to follow.

I'm not so sure that this actually needs to be a head2head issue, since we do generally support updates from whatever previous Drupal version, so the update function will need to be ported to D7 as well and committed here.

D6 backport.

Patch in #14 applies nicely to D6. I just stumbled upon this when looking through my slow query logs.

This is probably RTBC.

14: semaphore_value_index-800432-d6-14.patch queued for re-testing.

I think we can safely mark this as won't fix given this stage of D6's life cycle.

We are seeing this with Drupal 6 - no harm in at least having a working patch

Here's a re-roll. Something changed in the code comment at the end of the file that was causing the patch to not apply.