Hi there,

Cool module! 8-)

I will be using it for one of my systems. Now... there is a problem with the fact that the default roles are added inside the Account information fieldset, whereas, you add them "as is".

There is a patch that will put the roles in the right fieldset. If the fieldset does not exist, as far as I know, it works too. But we may want to test that? Not sure... since those do not appear on the registration form, then we should be just fine.

Thank you.
Alexis Wilke

CommentFileSizeAuthor
#8 role_preserve_form_array.patch1.18 KBAnonymous (not verified)
#2 role_delegation-fieldset2.patch1.68 KBteliseo
role_delegation-fieldset-6.x.patch810 bytesAlexisWilke

Comments

AlexisWilke’s picture

AlexisWilke commented
Status: Needs review » Needs work

Hmm.... that breaks the admin Add User window. Weird... I guess it merges the arrays in a way that's not good enough and the order in which it is done cannot be controlled. Too bad.

teliseo’s picture

teliseo commented
StatusFileSize
new role_delegation-fieldset2.patch1.68 KB

Attached patch fixes the problem in comment #1 by working around a bug in core (#227690: hook_user('register') implementations can't inject fields into account (the main one) fieldset), and additionally puts the notify element in the right place. The original issue may seem minor, but I’m fixing it for proper integration with my changes to Role Expire (#831232: Problem working with role delegation module for non admin/uid 1).

AlexisWilke’s picture

AlexisWilke commented
Status: Needs work » Needs review

teliseo,

Cool! The new patch looks good. 8-)

Thank you.
Alexis

AlexisWilke’s picture

AlexisWilke commented
Status: Needs review » Reviewed & tested by the community

Okay, I now tested and I can see that it works as expected. Great! Thanks teliseo.

Alexis

Andrew Schulman’s picture

Andrew Schulman commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch. I tested it, it works. Committed now in 6.x-1.x-dev.

I want to finish cleaning up a few more issues from the queue, and then I'll roll a new 6.x release, including this fix.

I looked for this problem in D7, but I couldn't reproduce it there. The form field is different, and I guess that #227690: hook_user('register') implementations can't inject fields into account (the main one) fieldset doesn't occur there either.

AlexisWilke’s picture

AlexisWilke commented

Cool! Thanks Andrew for taking the module over. 8-)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new role_preserve_form_array.patch1.18 KB

Why not the same for the role_preserve array?
Without the role_preserve under the account tree there was a compatibility problem with the account profile module.