The module does not work with popups. The problem is on the line 502 in hierarchical_select.js with the return statement. Removing this sentence is functioning properly.



Wim Leers’s picture

Title: Not working with popups » Compatibility with pop-ups
Status: Needs review » Fixed

Strange. Yet simple fix. Some testing did not reveal any problems, so I decided it's safe to go. Thanks, committed!


Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

digi24’s picture

Status: Closed (fixed) » Active

This commit is having some side effects for me:

I use a two level hierarchy vocabulary. Before this commit the behavior was as follows:
Changing the selection on the first hierarchy level results in a AJAX request to retrieve the second level terms. Changing the second level selection is instantaneous (no AJAX call).

After this patch every selection change leads to an AJAX request, even if it is unnecessary.

digi24’s picture

Status: Active » Needs work

more meaningful status

Wim Leers’s picture

Status: Needs work » Closed (fixed)

You're absolutely right, digi24. This was fixed in #1007492: Don't always perform a callback to the server when updating.

Wim Leers’s picture

Now also fixed for Drupal 5: http://drupal.org/cvs?commit=495496.