Its only a cosmetic problem. In the machine name, there should be at least a description of which glyphs can be used. Or the better way should be to check if the name is correct.

I try to use the semicolon, instead of underscore and normaly saved the view. In the blocks admin I found my new block, put it in chosen region, but it wont show up, until i change its machine name to containt underscore.

CommentFileSizeAuthor
#4 785036.patch1.32 KBbojanz
#3 785036-views-display_name_validation.patch1.32 KBdawehner
#1 785036-views-display_name_validation.patch1.26 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
785036-views-display_name_validation.patch1.26 KB

I added a description, and i added a validation

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Needs work

Does not apply right now.

Also, only one space after a period on a sentence, please.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
785036-views-display_name_validation.patch1.32 KB

quick rerole

bojanz’s picture

bojanz CreditAttribution: bojanz commented
FileSize
785036.patch1.32 KB

I still see two spaces after the period. Attached a quick reroll, if that wording is prefered.

However, I'd go with wording that matches the D7 UI:

This is the machine name of the display. It should contain only letters, numbers, and underscores. This name must be unique.

compared to the current proposal:

This is machine name of the display. It must contain only alphanumeric characters and underscores.

What do you think?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

What about

This is the machine name of the display. It must contain only letters, numbers, and underscores. This name must be unique.

?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

it was copied from d7 admin ui, so it's fine :0

merlinofchaos’s picture

merlinofchaos CreditAttribution: merlinofchaos commented
Status: Needs review » Fixed

Okay. Committed this to 6.x-3.x and 7.x-3.x with the wording change.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.