I got a DatabaseSchemaObjectExistsException while installing a module and the error message had the em tags htmlencoded.
DatabaseSchemaObjectExistsException: Table <em class="placeholder">cache_coder</em> already exists. in DatabaseSchema->createTable() (line 544 of /var/www/drupal7/includes/database/schema.inc).
The actual error was reported in the corresponding module (#780296: Error cache_coder already exists in DatabaseSchema on installation). However, shouldn't the em tags not have been html encoded?
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 780304-10-schema-errors.patch | 22.93 KB | dcam |
| #7 | 780304-7.patch | 22.33 KB | naxoc |
| #2 | at-no-percent.patch | 19.19 KB | Crell |
Comments
Comment #1
Crell commentedhm. That's because we used % instead of @ as the placeholder type there. Oopsies.
Comment #2
Crell commentedA simple but tedious patch.
Comment #4
Crell commentedOh for the love of pete... It applies just fine for me, you stupid bot.
Comment #5
Crell commented#2: at-no-percent.patch queued for re-testing.
Comment #7
naxoc commentedCame across this today. Still here. Reroll for D8.
Comment #8
Crell commentedWe probably want to remove those t() calls anyway, but at least for now this is a bugfix.
Marking for backport, too. Thanks, naxoc!
Comment #9
webchickI confess I did not review all of these in-depth. :P But scanned it and it seems to be just the same % to @ change over and over and over. Well. Except for that dirty limerick that naxoc added to settings.php (I kid :)).
Committed and pushed to 8.x. Thanks!
Moving back to 7.x.
Comment #10
dcam commentedBackported #7 to D7.
Comment #11
mgiffordSo the changeover "% to @ change over" is just getting the format_string right.
It's in D8. It applies nicely at D7 (and it installs easily). I can't see any problem with marking this RTBC.
Comment #14
dcam commentedYet another random failure.
Comment #17
dcam commentedComment #20
dcam commentedComment #23
dcam commentedComment #26
dcam commentedComment #27
David_Rothstein commentedCommitted to 7.x - thanks!
So technically this does break lots of translations, but I can't imagine any of them show up in a situation where it really matters.
Note there was one broken one in the patch, which I fixed on commit (was not present in Drupal 8) via this interdiff: