The seven theme only has CSS code for tr.odd and tr.even, while system.css has styling for tr.drag and tr.drag-previous as well. Because seven styling overrides system.css, the drag & dropped rows are hard to distinguish from the untouched.

See my screenshots for an example.

tabledrag-before.png: without patch, only the yellow asterix distinguishes the dragged row from the others.
tabledrag-after.png: with patch, now we also have styling for drag and drag-previous.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Georg’s picture

Status: Needs review » Needs work

Nice!

I tried it on the blocks list with all my browsers:
Firefox 3.6.3
IE8
Opera 10.51
Safari 4.0.5
Chrome 4.1.249.1045

Looks good, except for this Bug in IE #737632: tabledrag: menu children take top of left region or not at all in IE, but the patch of this issue behaves as expected.

+tr.drag{
+  background: #fe7;
+}
+tr.drag-previous{
+  background: #ed5;
+}

could you add a space between the css selecter and the opening bracket?

BarisW’s picture

Status: Needs work » Needs review
FileSize
588 bytes

Georg, thanks for testing!
I added the spaces, how stupid of me :)

Georg’s picture

BarisW, no one's stupid.

Looks good!
Now we need one more person to look at the patch to set this to rtbc.

seutje’s picture

I dunno about making the drag-previous darker than the other one, wouldn't it make more sense to make it lighter? it just seems rly dark and heavy to me

how about #ffb?

aspilicious’s picture

screenshot please :)

seutje’s picture

FileSize
27.11 KB
27.08 KB

sry, didn't change anything about the style while dragging, but added a screenshot for that as well

Georg’s picture

sutje, you'r right, it was a bit dark.
Your idea of marking it lighter looks better.
I'll test the patch over the weekend, if it didn't get committed till then. :-p

BarisW’s picture

Hi seutje, you're right. That looks better!
Looks good to me :)

Georg’s picture

Status: Needs review » Reviewed & tested by the community

Works in all Browsers I tried: IE6, IE7, IE8, Firefox, Opera, Safari, Chrome

RTBC

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Looks better. Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.