Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The seven theme only has CSS code for tr.odd and tr.even, while system.css has styling for tr.drag and tr.drag-previous as well. Because seven styling overrides system.css, the drag & dropped rows are hard to distinguish from the untouched.
See my screenshots for an example.
tabledrag-before.png: without patch, only the yellow asterix distinguishes the dragged row from the others.
tabledrag-after.png: with patch, now we also have styling for drag and drag-previous.
Comment | File | Size | Author |
---|---|---|---|
#6 | dropped | 27.08 KB | seutje |
#6 | dragging | 27.11 KB | seutje |
#4 | 777428-seven-drag-styling-4.patch | 411 bytes | seutje |
#2 | seven-drag-styling2.patch | 588 bytes | BarisW |
seven-drag-styling.patch | 586 bytes | BarisW | |
Comments
Comment #1
Georg CreditAttribution: Georg commentedNice!
I tried it on the blocks list with all my browsers:
Firefox 3.6.3
IE8
Opera 10.51
Safari 4.0.5
Chrome 4.1.249.1045
Looks good, except for this Bug in IE #737632: tabledrag: menu children take top of left region or not at all in IE, but the patch of this issue behaves as expected.
could you add a space between the css selecter and the opening bracket?
Comment #2
BarisW CreditAttribution: BarisW commentedGeorg, thanks for testing!
I added the spaces, how stupid of me :)
Comment #3
Georg CreditAttribution: Georg commentedBarisW, no one's stupid.
Looks good!
Now we need one more person to look at the patch to set this to rtbc.
Comment #4
seutje CreditAttribution: seutje commentedI dunno about making the drag-previous darker than the other one, wouldn't it make more sense to make it lighter? it just seems rly dark and heavy to me
how about #ffb?
Comment #5
aspilicious CreditAttribution: aspilicious commentedscreenshot please :)
Comment #6
seutje CreditAttribution: seutje commentedsry, didn't change anything about the style while dragging, but added a screenshot for that as well
Comment #7
Georg CreditAttribution: Georg commentedsutje, you'r right, it was a bit dark.
Your idea of marking it lighter looks better.
I'll test the patch over the weekend, if it didn't get committed till then. :-p
Comment #8
BarisW CreditAttribution: BarisW commentedHi seutje, you're right. That looks better!
Looks good to me :)
Comment #9
Georg CreditAttribution: Georg commentedWorks in all Browsers I tried: IE6, IE7, IE8, Firefox, Opera, Safari, Chrome
RTBC
Comment #10
Dries CreditAttribution: Dries commentedLooks better. Committed to CVS HEAD.