Here come a new patch with viewsd support for UUIDs.

It's now possible to pass a taxonomy UUID and a vocabulary UUID as a parameter.

It's also possible to sort and to display the values of taxonomy uuid and vocabulary uuid.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Crell’s picture

Status: Needs review » Needs work

I totally support this, but the patch doesn't apply. :-(

Pedro Lozano’s picture

Status: Needs work » Needs review
FileSize
3.48 KB
Brandonian’s picture

FileSize
1.21 KB

Updated uuid.views.inc file based on #2. Includes all the tables involved with UUID. Fairly ignorant on how to add non-existent files to a CVS patch, so if anyone would like to patch-ify, that'd be awesome. ;-)

presich’s picture

Sorry, guys, but where should I put this file to make my views work properly?

Brandonian’s picture

I have mine in a folder named views, which would make the file hierarchy (path to uuid module) -> views -> uuid.views.inc

presich’s picture

I put it in sites/all/modules/uuid/views but nothing changes. I also tried to put it in sites/all/modules/views but the result was the same.

Shouldn't I make another changes somewhere else or put the patch #2 before?

recidive’s picture

Status: Needs review » Needs work

@presich: you should apply the patch (manually since I think it'll not apply anymore), in order to make it implement hook_views_api().

Moving to "needs work" as the patch needs a re-roll.

presich’s picture

Thanks, I've understood already and made it work properly. Thanks for the module and patch.

When do you plan to put the patch in recommended version?

recidive’s picture

I need a working patch to test, could you generate one and attach to this issue?

arski’s picture

Will this also make node UUID available as one of the fields in a view?

Cheers

q0rban’s picture

Status: Needs work » Needs review
FileSize
1.7 KB

Aw, I suppose I should have looked here before writing this myself. /me fails.

Oh well, here's my stab at it. For some reason drupal_get_schema('uuid') wasn't loading up the schema, so I manually call uuid_schema() here.

q0rban’s picture

FileSize
1.72 KB

Whoopsie, let me try that again. ;)

Pol’s picture

Latest patch working flawlessly !

Status: Needs review » Needs work

The last submitted patch, uuid-776216-12.patch, failed testing.

Pol’s picture

Status: Needs work » Needs review

#12: uuid-776216-12.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, uuid-776216-12.patch, failed testing.

phayes’s picture

I've re-rolled an improved patch.

This one uses hook_views_data instead of hook_views_data_alter. Since we are only exposing additional fields / tables to views, this is the proper way to to do it.

This also allows us to filter, sort, and use as arguments UUID fields.

Note that this new patch is in git format.

Thanks!

phayes’s picture

Status: Needs work » Needs review
Pol’s picture

The patch works perfectly good here.

colan’s picture

Status: Needs review » Reviewed & tested by the community
colan’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
2 KB

The above patch no longer applies to the latest dev, as there's now a new function in there. This one should do the trick.

Crell’s picture

It looks like there's a couple of whitespace issues in #21 that need to be corrected. (Look for trailing whitespace on the lines that have no content. It's best to set your IDE to be very aggressive in trimming trailing whitespace.) Leaving needs review now for the test bot, but those will need to be corrected either way.

colan’s picture

I struggled with a bunch of Git options to do this automatically, but none of them worked. After getting thoroughly frustrated, I thought I'd try squeaking this by without anyone noticing (even the bot). Now that I've been caught, I was forced to figure out how to find these with Vim. For those of you that care, you can set this up with the info over at http://vim.wikia.com/wiki/Highlight_unwanted_spaces.

Specifically, I used:

" Find unwanted whitespace before & after insert mode.
autocmd InsertEnter * match ExtraWhitespace /\s\+\%#\@<!$/
autocmd InsertLeave * match ExtraWhitespace /\s\+$/

" Highlight unwanted whitespace.
highlight ExtraWhitespace ctermbg=darkgreen guibg=darkgreen

Now if someone can tell me how to properly use git format-patch from a client repository (i.e. not a clone of one from d.o), I'd really appreciate it. It either showed the full path, or when skipped, didn't apply.

Whitespace-less patch attached!

Status: Needs review » Needs work

The last submitted patch, views_support_for_uuid-776216-7.patch, failed testing.

colan’s picture

Problem with the test bot?

skwashd’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, views_support_for_uuid-776216-7.patch, failed testing.

skwashd’s picture

The bot worked as expected this time.

The patch needs to be rerolled using the instructions here http://drupal.org/node/324268/git-instructions/6.x-1.x The test bots no longer test patches which aren't generated from git.

Mile23’s picture

I noticed the file is called views_support_for_uuid-776216-7.patch, which might mean it's patched against the D7 version. The issue is for the D6 version. Could this be the cause of trouble?

Also: The Coder module is super-ultra helpful in finding stylistic problems like too much whitespace. http://drupal.org/project/coder

colan’s picture

Assigned: Unassigned » colan

Looks like we now need to work out of specific d.o git repositories instead of clients' git repositories. More repositories to set up. *sigh*

colan’s picture

Status: Needs work » Needs review
FileSize
2.42 KB

I removed all the whitespace, but when I apply it, I still get:

Checking patch uuid.module...
Checking patch uuid.views.inc...
/home/colans/views_support_for_uuid-776216-8.patch:38: new blank line at EOF.
+
Applied patch uuid.module cleanly.
Applied patch uuid.views.inc cleanly.
warning: 1 line adds whitespace errors.

Hopefully that'll suffice. I can't find any documentation anywhere on this on d.o using "git format-patch".

SocialNicheGuru’s picture

I need to use uuid and uuid_features to create features and want to fully understand how using this module will effect development.

Does this mean that I have to rewrite my view to use the uuid instead of taxonomy term?

Jim Kirkpatrick’s picture

Status: Needs review » Active

Applied patch in #31, UUID fields now appearing, thanks.

colan’s picture

Status: Active » Reviewed & tested by the community

Great. Fixing status.

recidive’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Commited to 6.x-1.x, thanks!

This should now be ported to 7.x. Patches welcome.

skwashd’s picture

The D7 port is currently under review - again! I think this should be postponed until that is sorted.

recidive’s picture

Status: Patch (to be ported) » Postponed

Postponed until we have a consensus on the database structure.

skwashd’s picture

Status: Postponed » Patch (to be ported)

Thanks to dixon_'s work this has been resolved. Sadly, I won't have any time soon to work on porting the patch.

fabsor’s picture

Assigned: colan » Unassigned
Status: Patch (to be ported) » Needs review
FileSize
1.66 KB

Here is a D7 version of the views integration. It seems to work well after a quick test.

John Morahan’s picture

FileSize
1.67 KB

Indeed it does. I think it should use $entity_info['label'] though, rather than ucwords($table), right?

dixon_’s picture

Status: Needs review » Fixed

Thanks for the work on this. I've committed John's patch from #40 with some minor adjustments/improvements. I'm rolling a release right now, so it should be available soon.

Again, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.