Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Here come a new patch with viewsd support for UUIDs.
It's now possible to pass a taxonomy UUID and a vocabulary UUID as a parameter.
It's also possible to sort and to display the values of taxonomy uuid and vocabulary uuid.
Comment | File | Size | Author |
---|---|---|---|
#40 | 776216.patch | 1.67 KB | John Morahan |
#39 | views_support_for_uuid-776216-39.patch | 1.66 KB | fabsor |
#31 | views_support_for_uuid-776216-8.patch | 2.42 KB | colan |
#23 | views_support_for_uuid-776216-7.patch | 1.98 KB | colan |
#21 | views_support_for_uuid-776216-6.patch | 2 KB | colan |
Comments
Comment #1
Crell CreditAttribution: Crell commentedI totally support this, but the patch doesn't apply. :-(
Comment #2
Pedro Lozano CreditAttribution: Pedro Lozano commentedComment #3
Brandonian CreditAttribution: Brandonian commentedUpdated uuid.views.inc file based on #2. Includes all the tables involved with UUID. Fairly ignorant on how to add non-existent files to a CVS patch, so if anyone would like to patch-ify, that'd be awesome. ;-)
Comment #4
presich CreditAttribution: presich commentedSorry, guys, but where should I put this file to make my views work properly?
Comment #5
Brandonian CreditAttribution: Brandonian commentedI have mine in a folder named views, which would make the file hierarchy (path to uuid module) -> views -> uuid.views.inc
Comment #6
presich CreditAttribution: presich commentedI put it in sites/all/modules/uuid/views but nothing changes. I also tried to put it in sites/all/modules/views but the result was the same.
Shouldn't I make another changes somewhere else or put the patch #2 before?
Comment #7
recidive CreditAttribution: recidive commented@presich: you should apply the patch (manually since I think it'll not apply anymore), in order to make it implement hook_views_api().
Moving to "needs work" as the patch needs a re-roll.
Comment #8
presich CreditAttribution: presich commentedThanks, I've understood already and made it work properly. Thanks for the module and patch.
When do you plan to put the patch in recommended version?
Comment #9
recidive CreditAttribution: recidive commentedI need a working patch to test, could you generate one and attach to this issue?
Comment #10
arski CreditAttribution: arski commentedWill this also make node UUID available as one of the fields in a view?
Cheers
Comment #11
q0rban CreditAttribution: q0rban commentedAw, I suppose I should have looked here before writing this myself. /me fails.
Oh well, here's my stab at it. For some reason drupal_get_schema('uuid') wasn't loading up the schema, so I manually call uuid_schema() here.
Comment #12
q0rban CreditAttribution: q0rban commentedWhoopsie, let me try that again. ;)
Comment #13
PolLatest patch working flawlessly !
Comment #15
Pol#12: uuid-776216-12.patch queued for re-testing.
Comment #17
phayes CreditAttribution: phayes commentedI've re-rolled an improved patch.
This one uses hook_views_data instead of hook_views_data_alter. Since we are only exposing additional fields / tables to views, this is the proper way to to do it.
This also allows us to filter, sort, and use as arguments UUID fields.
Note that this new patch is in git format.
Thanks!
Comment #18
phayes CreditAttribution: phayes commentedComment #19
PolThe patch works perfectly good here.
Comment #20
colanComment #21
colanThe above patch no longer applies to the latest dev, as there's now a new function in there. This one should do the trick.
Comment #22
Crell CreditAttribution: Crell commentedIt looks like there's a couple of whitespace issues in #21 that need to be corrected. (Look for trailing whitespace on the lines that have no content. It's best to set your IDE to be very aggressive in trimming trailing whitespace.) Leaving needs review now for the test bot, but those will need to be corrected either way.
Comment #23
colanI struggled with a bunch of Git options to do this automatically, but none of them worked. After getting thoroughly frustrated, I thought I'd try squeaking this by without anyone noticing (even the bot). Now that I've been caught, I was forced to figure out how to find these with Vim. For those of you that care, you can set this up with the info over at http://vim.wikia.com/wiki/Highlight_unwanted_spaces.
Specifically, I used:
Now if someone can tell me how to properly use git format-patch from a client repository (i.e. not a clone of one from d.o), I'd really appreciate it. It either showed the full path, or when skipped, didn't apply.
Whitespace-less patch attached!
Comment #25
colanProblem with the test bot?
Comment #26
skwashd CreditAttribution: skwashd commented#23: views_support_for_uuid-776216-7.patch queued for re-testing.
Comment #28
skwashd CreditAttribution: skwashd commentedThe bot worked as expected this time.
The patch needs to be rerolled using the instructions here http://drupal.org/node/324268/git-instructions/6.x-1.x The test bots no longer test patches which aren't generated from git.
Comment #29
Mile23I noticed the file is called views_support_for_uuid-776216-7.patch, which might mean it's patched against the D7 version. The issue is for the D6 version. Could this be the cause of trouble?
Also: The Coder module is super-ultra helpful in finding stylistic problems like too much whitespace. http://drupal.org/project/coder
Comment #30
colanLooks like we now need to work out of specific d.o git repositories instead of clients' git repositories. More repositories to set up. *sigh*
Comment #31
colanI removed all the whitespace, but when I apply it, I still get:
Hopefully that'll suffice. I can't find any documentation anywhere on this on d.o using "git format-patch".
Comment #32
SocialNicheGuru CreditAttribution: SocialNicheGuru commentedI need to use uuid and uuid_features to create features and want to fully understand how using this module will effect development.
Does this mean that I have to rewrite my view to use the uuid instead of taxonomy term?
Comment #33
Jim Kirkpatrick CreditAttribution: Jim Kirkpatrick commentedApplied patch in #31, UUID fields now appearing, thanks.
Comment #34
colanGreat. Fixing status.
Comment #35
recidive CreditAttribution: recidive commentedCommited to 6.x-1.x, thanks!
This should now be ported to 7.x. Patches welcome.
Comment #36
skwashd CreditAttribution: skwashd commentedThe D7 port is currently under review - again! I think this should be postponed until that is sorted.
Comment #37
recidive CreditAttribution: recidive commentedPostponed until we have a consensus on the database structure.
Comment #38
skwashd CreditAttribution: skwashd commentedThanks to dixon_'s work this has been resolved. Sadly, I won't have any time soon to work on porting the patch.
Comment #39
fabsor CreditAttribution: fabsor commentedHere is a D7 version of the views integration. It seems to work well after a quick test.
Comment #40
John Morahan CreditAttribution: John Morahan commentedIndeed it does. I think it should use $entity_info['label'] though, rather than ucwords($table), right?
Comment #41
dixon_Thanks for the work on this. I've committed John's patch from #40 with some minor adjustments/improvements. I'm rolling a release right now, so it should be available soon.
Again, thanks.