I'm trying to create a D7 version of an installation profile - with a make file, and get the message:
The 'core' attribute 7.0-alpha3 has an incorrect format. [error]
Is this by design because D7 is an alpha release, or a bug because it isn't recognising it properly, or have I put it in wrongly?
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | drush_make_core_regex_fix.patch | 824 bytes | hunmonk |
Comments
Comment #1
dwwSounds like a bug in drush make. Are you doing this on the command-line directly with drush, or are you using the UI on drupal.org?
Comment #2
juliangb commentedUI in drupal.org.
I first found it when trying to create a release - and then also when I tried the 'verify make file' function.
Comment #3
hunmonk commentedthis is a problem in
drush_make_validate_info_file()-- the regex doesn't support any alpha|beta|rc releases at all:Comment #4
dwwSo it's not just in the d.o-specific plugin for drush make, after all. Moving component...
Comment #5
hunmonk commentedhow's this look?
Comment #6
dwwUntested, but that visually appears fine to me.
It's case-sensitive, though, so you might want
[a-zA-Z0-9]+just in case (although our version strings are _supposed_ to be lowercase). Or, at that point, you could just use 1 or more "word" characters:\w+since it's basically equivalent except \w also matches underscores.*shrug*
Comment #7
hunmonk commented.make files are specified according to the visible version string (the kind you'd see on the title of release nodes), so for consistency i'll keep this validation the same.
Comment #8
dmitrig01 commentedfixed, thanks