I saw there's a new version, and being this module a very sensitive of one of my clients I was wondering if there's any particular note on the upgrade. I've checked the changes and I two things caught my eye. The improved pane on checkout and the order edition with product prices change. My client uses a lot the admin order to create/edit orders, after the upgrade, would they have to know something in advance? The same question goes for the checkout, would there be any noticeable change after the upgrade, or just visual stuff? Any other not on the subject will be appreciated.

I tried to give the code a very quick review before going with tests, specially in the order admin edition screen, and I wonder, wouldn't that have to be done only if the setting to enter prices including vat is set. It seems in the code that it was done nonetheless.

Thanks,
a.=

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Fixed

I have tested the admin order edit functionality with different combinations of the price editing options and all works as expected. In uc_vat_form_uc_order_edit_products_form_alter() and _uc_vat_uc_order_edit_products_submit() only the selected price fields are affected due to the use of _uc_vat_attribute_fields() to determine which fields to modify.

The checkout will revert to using the standard cart pane until the new cart pane is enabled in either checkout settings or VAT settings. Maybe this could have been enabled by default in the new version, but it is only a visual change at the top of the checkout page. The order total preview pane is unchanged by this.

If you are able to test this on a copy of your client's site and find any problems, please let me know.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.