Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Added str_replace() instead of preg_replace().
Comment | File | Size | Author |
---|---|---|---|
#1 | ctools_css_assemble.patch | 675 bytes | aosodoev |
ctools_css_assemble.patch | 657 bytes | aosodoev | |
Comments
Comment #1
aosodoev CreditAttribution: aosodoev commentedSorry, correct file
Comment #2
sdboyer CreditAttribution: sdboyer commentedSome steps to replicate, please? This is a simple enough fix, and the subject strings do not seem to merit a preg_replace() in the first place, so I'd really like to commit it. But there's absolutely _nothing_ here for me to go on, so I can't quite bring myself to pull the trigger.
Comment #3
aosodoev CreditAttribution: aosodoev commentedThere is preg_replace(", ", ",\n", $selector_str) at the moment. It issues warning and returns NULL, that's why I replaced it by str_replace, I think it's just a typo.
Comment #4
aosodoev CreditAttribution: aosodoev commentedwarning: preg_replace(): No ending delimiter ',' found in /home/alexey/work/vhosts/drupal.test/docs/sites/all/modules/ctools/includes/css.inc on line 217
Comment #5
sdboyer CreditAttribution: sdboyer commentedWow, I'm kinda amazed nobody caught that before. Thanks, committed.