Not that big of a deal, but the Grid block outputs an extra empty "<tr></tr>" pair which makes the site not to validate.
Lines 126-131 of gallery_block.inc

if ($col >= $num_cols) {
                $col = 0;
                $new_html .= '</tr><tr>';
              }
            }
            $new_html .= '</tr></table>';

As if how it's composed now you'll have to rewrite the loop for the output, it'll always out put that extra pair in the end.
I will see if I can make a patch when I have my head on straight.

CommentFileSizeAuthor
#2 gallery_3.patch1.1 KBhe_who_shall_not_be_named

Comments

alexmarkley’s picture

alexmarkley commented

I noticed this problem too, as we try to maintain XHTML Strict compliance on my site.

Since I wanted to use this block, I patched it to read like so:

(starting around line 121)

            $new_html .= '<table><tr>';
            $col = 0;
            $row = 0;
            foreach ($images as $current_image) {
              $new_html .= '<td style="text-align:center;">' . $current_image . '</td>';
              $col++;
              if ($col >= $num_cols) {
                $col = 0;
                $row++;
                if($row < $num_rows) $new_html .= '</tr><tr>';
              }
            }
            $new_html .= '</tr></table>';
            $new_html .= '</div></div>';
            $block['content'] .= $new_html;

All I did was make it avoid creating the last "

" when it knows it's on the last row.

he_who_shall_not_be_named’s picture

he_who_shall_not_be_named commented
Status: Active » Needs review
StatusFileSize
new gallery_3.patch1.1 KB

The patch moved here from a duplicate issue. This patch is a bit cleanest.

kiz_0987’s picture

kiz_0987 commented
Status: Needs review » Fixed

Applied. Thanks.

kiz_0987’s picture

kiz_0987 commented
Status: Fixed » Closed (fixed)