marcushenningsen [marcushenningsen]

Hi,

The module works fine, coding standards are respected. This is a very simple module. Only thing I see is that you don't need a "version" inside your .info file. Otherwise, you might want to tidy up those commented lines.

I can see why you made this module. But I think a client can achieve exactly the same thing by creating a custom block and putting it inside the footer. I know, it's a bit more tedious, but is it worth another module ?

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

But I think a client can achieve exactly the same thing by creating a custom block and putting it inside the footer.

It is possible, but all users who need to change the block should have the permission of administer blocks, which is a little too much for just changing the footer.

The license file must not be included, as it is not possible to commit that file.

There are two optimizations that should be done to the code (they are not blockers for the approval of the application, though):

1.     'access callback' => 'user_access',
   

   That is the default value, and it should not be set.

2.       unset($form['site_footer']['#type']);
         unset($form['site_footer']['#title']);
         unset($form['site_footer']['#default_value']);
         unset($form['site_footer']['#description']);
   

   It can simply be written as

         unset($form['site_footer']);
   

There have not been replies in more than a week.

Looks like the suggested changes were made. Account approved. I notice you still have the license.txt in the zip file. Don't forget that you should not commit that to the project as it will be done automatically.

Michelle