Hallo,

I've just started to use the invite.module on my test site in German. Very nice module.

But when I tried to translate all the messages into Geman I found, that some of them are not found by localization module. So, they cannot be translated, eg: "delete", "pending" etc.

My guess what the reason could be is, that these terms have double quotes around them in invite.module, eg. line 259. Shouldn't they have single quotes around them in order to be translatable?

Since I'm not really familiar with all the mechanics of drupal modules and translations I didn't dare to change all the double quotes into single once.
I would be very greatful for a hint because I'd really like to use this module in German.

Thanks,

Comments

hausig’s picture

hausig commented
Title: double quotes and translation » Correction?

Actually, I am not sure if terms in order to be handled by the localization module should be wraped in single or double quotes. But I guess it has to be consistent. Instead, the code of invite.module shows a mix of single and double quotes.
Which should be used in order to make all terms translatable?

Nick Wilson’s picture

Nick Wilson commented
Assigned: Unassigned » Nick Wilson
Category: bug » task

Hi, i beleive this should work now, could you try the cvs version and let me know? http://cvs.drupal.org/viewcvs/drupal/contributions/modules/invite/

Hayakawa’s picture

Hayakawa commented

Nick can you please update the cvs tar package on the project page?

Nick Wilson’s picture

Nick Wilson commented

Im not actually sure how to do that -- but ill see if i can work it out...

Nick Wilson’s picture

Nick Wilson commented

This is done by a script automatically -- at least some time back there was a bug with it not changing the date, so im not sure if that's fixed, but it should be current in the next hour or 2 i guess

hausig’s picture

hausig commented
Category: task » bug

Thanks Nick for quick reply. I've changed it and it works better.

But I've got another problem: Members invited other people. When they tried to use the join_link I get "registration code failed" a few times in my admin log.
My settings:
- authenticated users only have access to invite
- invited users should be activated as authenticated

Is this a bug or what am I doing wrong?

It says it would work only for the option 'Visitors can create accounts but administrator approval is required.' How can I change it so it work also for visitors can create accounts without approval?

I am a bit confused about the versions. Which one should I use now (running 4.7.2 with the patch to 4.7.3)?

Thanks

Nick Wilson’s picture

Nick Wilson commented

The current CVS version is built for 4.7.2 (though will undoubtably work for 4.7.3), you should use that one for now -- i will work at putting this code in the 4.7 branch, but im quite new to cvs and would like to have Robert Douglass who's worked on this module also review it before I do.

If the problem continues, please post this with as much detail as poss to a new issue, and i'll get to it as soon as time allows.

Brumisek’s picture

Brumisek commented
Title: Correction? » Invite module - no UTF-8 mail coding

I installed Invite module and when I send e-mail this is not UTF-8 coded. I see strange letters in my language. All other e-mail functions of drupal system are totally OK. Any quick HINT idea? Thank you!

Nick Wilson’s picture

Nick Wilson commented

Hi, if you can give me an example of a module that handles email correctly, i'll work it into this one...

Brumisek’s picture

Brumisek commented

Umm ... well .. I don't understand. I don't using any special modules. Only standard drupal modules. All other functions (who e-mailing) are totally OK. For example simplenews.module. This module sending HTML e-mails with right coding.
This module (invite) sending plain-text messages and there si not UTF-8 coding.

What I can make for you to help?

Nick Wilson’s picture

Nick Wilson commented

Perfect. Simplenews will be a good moeule for me to look at, thanks.

I'll take a look at it and work out what we need to do to make invite work nicely aswell.

Brumisek’s picture

Brumisek commented

Thank you very much. I'm looking forward to your spying...
BTW: Any luck?

Nick Wilson’s picture

Nick Wilson commented

Not yet, but im tied up with other things right now. If you can do it, feel free to submit a patch, otherwise im afraid it may be a week or 2 before i can do this..

Brumisek’s picture

Brumisek commented

OK, I'll wait. Thank you anyway!

ajk’s picture

ajk commented
Status: Active » Fixed

see http://drupal.org/node/85708

I'm pretty sure my patch on that issue addresses all the areas where t() was either incorrectly used or just plain missing. So, I'm going to mark this "fixed" by that issue. If it isn't then please change the status and give some more details.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)