There may be a slight performance gain from this as getcwd() might make a system call.

CommentFileSizeAuthor
#7 shutdown-cwd.patch1.01 KBjbrown
#4 761212.patch537 bytesdroplet
#2 use-drupal-root-constant.patch652 bytesjbrown
use-drupal-root-constant.patch1.31 KBjbrown
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, use-drupal-root-constant.patch, failed testing.

jbrown’s picture

jbrown CreditAttribution: jbrown commented
Priority: Normal » Minor
FileSize
use-drupal-root-constant.patch652 bytes
jbrown’s picture

jbrown CreditAttribution: jbrown commented
Status: Needs work » Needs review
droplet’s picture

droplet CreditAttribution: droplet commented
FileSize
761212.patch537 bytes

re-roll against head

Freso’s picture

Freso CreditAttribution: Freso commented
Status: Needs review » Reviewed & tested by the community

Passes tests and makes good sense. RTBC, AFAICT.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

This seems like a straight-forward fix that shouldn't break anything (famous last words :D).

Committed to HEAD.

jbrown’s picture

jbrown CreditAttribution: jbrown commented
Title: Always use DRUPAL_ROOT instead of getcwd() » Simplify setting of CWD in _drupal_shutdown_function()
Category: bug » feature
Status: Fixed » Needs review
FileSize
shutdown-cwd.patch1.01 KB

The code is actually more complicated than it needs to be.

Every callback has the same 'cwd' value - DRUPAL_ROOT.

_drupal_shutdown_function() is setting the cwd for each callback, but they will always be the same.

The cwd only needs to be set once a the start of the function.

See notes section at http://php.net/register-shutdown-function

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

looks good.

Eric_A’s picture

Eric_A CreditAttribution: Eric_A commented
Category: feature » bug
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.