Looking through the code with Robert today - I realized that the code in apacesolr_search_execute() is totally insufficient to allow multiple modules to run their own searches. We shoudl refactor the code while preserving BC by giving modified function calls default params.

CommentFileSizeAuthor
#1 759638-query-do-1.patch7.45 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new 759638-query-do-1.patch7.45 KB
robertdouglass’s picture

robertdouglass commented

Peter, I like the approach. I'm also secretly hoping you'll roll it for 6.2 as well.

pwolanin’s picture

pwolanin commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Needs review » Patch (to be ported)

unfortunately the patch doesn't apply cleanly to 6.x-2.x, so needs some manual porting.

committed to 6.x-1.x, but bears some testing.

jpmckinney’s picture

jpmckinney commented
Version: 6.x-2.x-dev » 5.x-2.x-dev

Committed to 6-2 http://drupal.org/cvs?commit=361244

Do we need a D5 port?

pwolanin’s picture

pwolanin commented

probably makes sense to port it there as well for consistency.

jpmckinney’s picture

jpmckinney commented
Status: Patch (to be ported) » Fixed

Committed to 5-2 http://drupal.org/cvs?commit=361652

david lesieur’s picture

david lesieur commented

I really like that. That's what I meant with #473536: Allow multiple queries per page request.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.