The module Modal Frame CCK Editor transforms field type to value when field(s) are not being edited via the modal frame. Required date fields then fail date_combo_validate in date_elements.inc with the error:

The dates are invalid.

To reproduce,

1. create a node with a required date and a text field
2. enable modal editing on the text field
3. edit the text field, you will see the validation error on the date field

I waded thru the code and wasn't sure if the better approach was a quick bailout (like when the field $_POST is empty and the field is not required) or creating a new date_element_empty handler for field type value to re-validate the passed-thru value. Attached is the former applied against 2.x-dev (2010-Mar-09).

CommentFileSizeAuthor
date-widget-type-value.patch643 bytesjohn.money

Comments

john.money’s picture

john.money commented

Cross-referenced issue

john.money’s picture

john.money commented
Status: Active » Needs review
leon85321’s picture

leon85321 commented

Thx for the great fix, so far so good!

karens’s picture

karens commented

The thing you have to test on things like this is not so much if it fixes the original problem but whether it creates trouble anywhere else. So on a site with the patch disable the modal framework and test that date fields still work correctly. You have to test a lot of things (we really need a ton of tests for this module) -- what happens if you create complex repeating dates, empty dates, put dates into views filters and arguments. If any of those things break, we have a problem.

karens’s picture

karens commented
Status: Needs review » Postponed (maintainer needs more info)
arlinsandbulte’s picture

arlinsandbulte commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Nearly 6 months a a state of 'postponed (maintainer needs more info)'

I am going to close due to lack of interest.