CVS edit link for DmitryDrozdik

I created module for payment through the system of liqpay.com for Drupal 5 and Drupal 6 for system ubercart.
This module have settings on admin page.
This module is easy to work.
CommentFileSizeAuthor
#9 uc_liqpay.tgz20.99 KBddrozdik
#3 uc_liqpay.tgz20.91 KBddrozdik
#1 uc_liqpay.tgz20.93 KBddrozdik

Comments

ddrozdik’s picture

ddrozdik commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new uc_liqpay.tgz20.93 KB

This module provides Liqpay payment gateway through liqpay.com website, when using Drupal Ubercart.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

ddrozdik’s picture

ddrozdik commented
StatusFileSize
new uc_liqpay.tgz20.91 KB

My motivation this is not to lose the module and enable others to use it.
This is first module for payment system Liqpay on drupal.org, currently similar module not created, so not possible compare with other modules.
I added new version of module, because I changed some grammar errors.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

The motivation message should contain few paragraphs instead of few sentences explaining the features of the proposed project, and comparing it with the existing solutions; an existing solution is not only a module implementing the same exact solution (in this case the integration with Liqpay).

ddrozdik’s picture

ddrozdik commented

But I don't know what I should write. Can you show an example?

ddrozdik’s picture

ddrozdik commented

LiqPAY – is a payment system that allows easily send money from Visa or MasterCard cards to virtual account in Liqpay system linked to a mobile phone (cell phone) number.
Later on you may send money to other LiqPAY Account, withdraw money from LiqPAY system to your card or leave money at your Account and use them later.

This system is becoming popular in the world. Quite often used in Eastern Europe.
The module allows you to pay for goods stores internet via Liqpay. It is easy to use.
It contain minimum settings for connecting to the site, sufficient obtain merchant id and secret key in system liqpay.
How to use this module I wrote in readme file in archive module.
For the user using the module need only to the choice of payment system.
Similarly used webmoney on internet sites with system Ubercart.
If you need, I add screenshot.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review

Thanks for your reply; even though the motivation is far from being few paragraphs as required in http://drupal.org/cvs-application/requirements, I think it's enough.

ddrozdik’s picture

ddrozdik commented

Thanks) this is my first official module. I'll make a note on the future.

ddrozdik’s picture

ddrozdik commented
StatusFileSize
new uc_liqpay.tgz20.99 KB

I added some code in module. This is last version currently.

ddrozdik’s picture

ddrozdik commented

I think i'ts ok, true?

please tell me something,

greetings!

ddrozdik’s picture

ddrozdik commented
Title: DmitryDrozdik [dmitrydrozdik] » uc_liqpay module

Why are all silent? what to do further to publish the module?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: uc_liqpay module » DmitryDrozdik [dmitrydrozdik]
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno

I will review the code within 6 days from July 2.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed 
  1.   $path = base_path() . drupal_get_path('module', 'uc_liqpay');

    url() is probably the better function to use in this cases.

  2. Drupal schema descriptions are not passed to t().

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Component: Miscellaneous » miscellaneous

subscribe

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: miscellaneous » new project application
Issue summary: View changes