Support SVN revisions

Hello, need some feedback here please!

Fixed patch.

Thanks

Is this commit in the latest release ?
Still having problems.

Re-opening the bug, see description lower:

pounard@guinevere /var/www/drupal-installation-profiles/testing $ ./rebuild.sh 
Make new site in the current directory? (y/n): y
solrphpclient svn  --force --non-interactive checkout -r%s %s %s from http://solr-php-client.googlecode.com/svn/trunk.                                                   [ok]
pounard@guinevere /var/www/drupal-installation-profiles/testing $ ./rebuild.sh 
Make new site in the current directory? (y/n): y
Array
(
    [0] => svn  --force --non-interactive checkout -r%s %s %s
    [1] => 33
    [2] => http://solr-php-client.googlecode.com/svn/trunk
    [3] => /tmp/drush_make_tmp_1279210553/__build__/./modules/contrib/apachesolr/SolrPhpClient
)
solrphpclient svn  --force --non-interactive checkout -r%s %s %s from[ok]
http://solr-php-client.googlecode.com/svn/trunk.
pounard@guinevere /var/www/drupal-installation-profiles/testing $ svn  --force --non-interactive checkout -r33 http://solr-php-client.googlecode.com/svn/trunk /tmp/
A    /tmp/Apache
A    /tmp/Apache/Solr
A    /tmp/Apache/Solr/Service
A    /tmp/Apache/Solr/Service/Balancer.php
A    /tmp/Apache/Solr/HttpTransportException.php
A    /tmp/Apache/Solr/ParserException.php
A    /tmp/Apache/Solr/NoServiceAvailableException.php
A    /tmp/Apache/Solr/Exception.php
A    /tmp/Apache/Solr/Response.php
A    /tmp/Apache/Solr/Document.php
A    /tmp/Apache/Solr/Service.php
A    /tmp/Apache/Solr/InvalidArgumentException.php
A    /tmp/tests
A    /tmp/tests/Apache
A    /tmp/tests/Apache/Solr
A    /tmp/tests/Apache/Solr/Service
A    /tmp/tests/Apache/Solr/Service/BalancerTest.php
A    /tmp/tests/Apache/Solr/Service/TestAll.php
A    /tmp/tests/Apache/Solr/ResponseTest.php
A    /tmp/tests/Apache/Solr/DocumentTest.php
A    /tmp/tests/Apache/Solr/ServiceTest.php
A    /tmp/tests/Apache/Solr/TestAll.php
A    /tmp/tests/phpunit.xml
A    /tmp/tests/run.php
A    /tmp/tests/phpunit.bootstrap.inc
A    /tmp/tests/README
A    /tmp/COPYING
Révision 33 extraite.
pounard@guinevere /var/www/drupal-installation-profiles/testing $ echo $!

pounard@guinevere /var/www/drupal-installation-profiles/testing $

As you can see, manually writing the command line, all is ok (shell command returns nothing, which means no errors). But, when running throught Drush Make (non patched, vanilla version), it fails.

I'm trying to introspect why.

The current .make file is this one:

; $Id$
core = "6.x"
; SolrPhpClient revision 33, needed for apachesolr 6.x-2.x branch
libraries[solrphpclient][download][type] = "svn"
libraries[solrphpclient][download][revision] = "33"
libraries[solrphpclient][download][url] = "http://solr-php-client.googlecode.com/svn/trunk"
libraries[solrphpclient][directory_name] = "SolrPhpClient"
libraries[solrphpclient][destination] = "modules/contrib/apachesolr"

I'm running it with this script:

#!/bin/sh

# Cleanup target directory and run drush make
rm -rf modules libraries
drush make --working-copy --no-core --contrib-destination=. testing.make

Ok, forget this, I really have to learn how to read, please give me some sleep!