Hi.

Would be great if we had an option in the newsletter block configuration settings to remove the "User: Username" from being displayed in the block.

See related node: http://drupal.org/node/474306

Thanks a lot! - Alex

Comments

sutharsan’s picture

I don't want features like this in a module; features that can be accomplished with a simple form alter or theme override. If the interface is cluttered by a username we should remove it alltogether. I like to have UX input on this.

Satri’s picture

"If the interface is cluttered by a username we should remove it alltogether. I like to have UX input on this."

Thanks for your reply! My advice would be to remove the 'User: Username' info from the block entirely, since the user sees this only if he is logged in, it doesn't make sense to display the username again.

Thank you for your consideration -

TapSkill’s picture

I agree with Satri. The "User: ???" text is pretty pointless and doesn't look good.

mineshaftgap’s picture

"I don't want features like this in a module; features that can be accomplished with a simple form alter or theme override. If the interface is cluttered by a username we should remove it alltogether. I like to have UX input on this."

I am trying to do this with both a hook_form_alter and/or the simplenews-block.tpl.php but with the form, I can't get access to the user display as it is not in the $form array, and in the tpl it is just one $form variable so it is too late.

How are you purposing to do this via form_alter or a tpl?

Thanks,

msg

SebastienT’s picture

Subscribe!

I am also trying to remove the "User: ..." but can't figure out how. This feature isn't necessary imo as it is only shown when the user is logged in.
What could be nice is that the form looks like the one for anonymous users, but then with the user's email address already displayed in the input field.

simon georges’s picture

You should be able to do :

function my_module_form_alter($form_id, &$form) {
  global $user;
  if ($user->uid) {
    unset($form['display_mail']);
  }
}

(of course, you should add a test to only do that if you're on a simplenews-related block form).


Anyway, I fully support the proposition to remove it completely, as I had to do it for every client I worked with.

simon georges’s picture

Version: 6.x-1.0-rc6 » 6.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new1.02 KB

As it is not a bug fix, I'm moving the version to 6.x-2.x-dev. I provide a patch (for 6.x-2.x version) removing the "User: Username" field.
Before it is committed, it would be good to have opinion of User Inteface experts.

miro_dietiker’s picture

Status: Needs review » Fixed

I aggree with that. It is up to the design to indicate the login state to a user. We should not double that information.

committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.