Hello,

Attached is the revised .module file. I updated the module from the latest downloadable version (Has head been revised drastically?).

This branch causes the terms of use checkbox label to be run through a theme function (the @link link must be a themed link for our websites).

CommentFileSizeAuthor
#2 terms_of_use-theme_checkbox_label-744800-2.patch1.63 KBrooby
terms_of_use.zip2.45 KBjjchinquist

Comments

kars-t’s picture

kars-t commented
Status: Active » Needs work

Please make a real patch out of this

http://drupal.org/patch/create

rooby’s picture

rooby commented
Version: 6.x-1.10 » 7.x-1.1
Priority: Minor » Normal
Status: Needs work » Needs review
StatusFileSize
new terms_of_use-theme_checkbox_label-744800-2.patch1.63 KB

Here is a patch for this for drupal 7 that could be easily also ported to drupal 6.

kars-t’s picture

kars-t commented
Assigned: Unassigned » kars-t
kars-t’s picture

kars-t commented
Assigned: kars-t » Unassigned
Status: Needs review » Needs work

Hi

this lable is a HTML tag and I am not sure if you could put images inside. Can you please check if this is possible?

And you placed 

$checkbox_label = theme('terms_of_use_checkbox_label', array('node' => $node, 'checkbox_label' => $checkbox_label));

outside of the if line 77 so it always run. But the if if line 77 is a special case if there is a link to replace in the text. The theming call should be around line 100. Please rewrite this.

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented
Version: 7.x-1.1 » 7.x-1.x-dev
Issue summary: View changes

Should this be combined with #2076239: Theme function not implemented or vice versa?

adammalone’s picture

adammalone
Primary language English
Location San Francisco
commented
Related issues: +#2076239: Theme function not implemented
ivnish’s picture

ivnish
he/him
commented

Needs to reroll the patch against the latest dev

ivnish’s picture

ivnish
he/him
commented
Status: Needs work » Closed (outdated)

Closed due to inactivity. If it is relevant, we will open it again