If none of the cases are satisfied in hook_help(), $output is returned undefined. Drupal catches E_NOTICE errors in the drupal_error_handler() function in common.inc, but for performance it would be better to eliminate these errors all together.

Thanks for you work on a very useful module!
Chris

CommentFileSizeAuthor
#1 user_terms-743954-1.patch1.13 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new user_terms-743954-1.patch1.13 KB

The attached patch is a workaround to this issue.

Thanks,
Chris

joachim’s picture

joachim commented
Status: Needs review » Fixed

Good catch :)

Thanks for the patch. Committed to CVS.

#743954 by cpliakas: Fixed undefined variable $output in hook_help().

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.