file_check_directory() renamed to file_prepare_directory() (issue #517814: File API Stream Wrapper Conversion)
- entry in the upgrade docs and the cannonical queue created.

Notes at the issue queue said only documentation and coder support were outstanding. I do not know what else in that issue remains undocumented, I wasn't part of it, I only discovered this issue when running a coder upgrade this evening, so am trying to help doc what I found.

CommentFileSizeAuthor
#1 coder_upgrade-rename_file_check_directory.20100315.patch919 bytesdman

Comments

dman’s picture

dman commented
Status: Active » Needs review
StatusFileSize
new coder_upgrade-rename_file_check_directory.20100315.patch919 bytes

So it would appear that a patch would look like this?

diff -u -p -r1.43 coder_upgrade.other.inc
--- coder_upgrade/conversions/coder_upgrade.other.inc   15 Feb 2010 22:49:40 -0000      1.43
+++ coder_upgrade/conversions/coder_upgrade.other.inc   14 Mar 2010 14:05:08 -0000
@@ -539,6 +539,11 @@ function coder_upgrade_callback_function
       $editor->setParameters($item, array('array(' . $temp . ')'));
       break;
 
+    case 'file_check_directory':
+      // http://drupal.org/node/741970
+      $name['value'] = 'file_prepare_directory';
+      break;
+
     case 'file_scan_directory': // DONE

... that's not too hard I guess!

duellj’s picture

duellj commented
Component: Coder Upgrade » Upgrade Routines

Thanks dman,

Function call changes actually live in coder_upgrade.call.inc in upgrade_call_alter hooks.

Here's an upgrade routine:

/**
 * Implements hook_upgrade_call_file_check_directory_alter().
 */
function coder_upgrade_upgrade_call_file_check_directory_alter(&$item, &$reader) {
  $name = &$item->name;
  $name['value'] = 'file_prepare_directory';
}

and test function:

function example_file_check_directory() {
  file_check_directory($full_path, FILE_CREATE_DIRECTORY);
  file_check_directory('file/test', FILE_CREATE_DIRECTORY);
}
dman’s picture

dman commented

Thanks. I'm getting my head around the coder_upgrade thing. It's pretty well documented internally, but I've got a way to go before I grok the actual framework :-)
Well, I'm trying to doc as I go at least!
... now I'm wondering what to do with function calls that are entirely deprecated :-B (taxonomy_get_related, taxonomy_get_synonyms)

solotandem’s picture

solotandem commented
Assigned: Unassigned » solotandem
Category: task » feature
Status: Needs review » Fixed

Implemented in next dev release. (Finally.)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.