Under Chrome, Safari, Adobe Air... (not Firefox) the feedback window is half readable which make it is useless...
The patch attached adds jQuery animations to make Feedback window fully readable. Works perfectly under Firefox, Chrome, Safari, etc...

Comments

Michel Poulain’s picture

StatusFileSize
new730 bytes

Under Chrome, Safari, Adobe Air... (not Firefox) the feedback window is half readable which make it is useless...
The patch attached adds jQuery animations to make Feedback window fully readable. Works perfectly under Firefox, Chrome, Safari, etc...

sun’s picture

Status: Patch (to be ported) » Postponed (maintainer needs more info)

Could you post a screenshot, please?

dkruglyak’s picture

Priority: Normal » Critical
Status: Postponed (maintainer needs more info) » Needs work

I have the same problem with these browsers too.

I also found that Feedback module breaks JavaScript of collapsible fieldsets in Chrome and Firefox (only ones I tested). Not even sure where to start debugging it, just collapsible fieldsets appear dead on all forms and do not expand. Wondering if anyone can reproduce and debug that.

ckreutz’s picture

StatusFileSize
new18.17 KB

Have the same problem with Chrome and Safari. Added a small screenshot attached. The above patch did not help in my case or I did something wrong.

UPDATE: Works fine more me too. Thanks!

webmasterkai’s picture

Patch works for me. I like the solution.

alexpott’s picture

Patch works for me too

jody lynn’s picture

StatusFileSize
new39.54 KB

I have this problem with every site I work on using Chrome. The patch didn't solve it on the theme I tested with (Rubik)

charos’s picture

StatusFileSize
new15.48 KB

Same issue with Chrome 5 beta

joostvdl’s picture

Patch #1 is working

charos’s picture

Can you please post the browser(s) you tried with the patch? Thanks

Archnemysis’s picture

#1 worked for me in Google Chrome 5.0.375.55 and cuased no problems in FireFox 3.6.3; Internet Explorer 8

Archnemysis’s picture

I should mention that I had changed my feedback.css to display the pop-up on the top left instead of on the bottom right. To keep from having issues, I needed to change patch #1 on lines 51 and 56 to have the position values reflect left instead of right. Not sure if it is a good idea to hard code in CSS values in the java script, but that may be the only solution.

mrsimonelliott’s picture

Status: Needs work » Reviewed & tested by the community

#1 worked for me. Tested in:
IE7
IE8
FF3.6.3
Chrome 5.03
safari 3.12
opera 9.52

openmediaforge.org’s picture

The patch from #1 fixed the problem. I tested it with:

Firefox 3.6.3
Google Chrome 5.0.375.55
Opera 10.10 build 4742

all on Linux.

socialnicheguru’s picture

StatusFileSize
new14.01 KB

this doesn't seem to quite work in Safari Version 5.0 (5533.16)

socialnicheguru’s picture

Status: Reviewed & tested by the community » Needs work

changed to reflect the error in #15

scottrouse’s picture

Patch in #1 corrects the issue on the following browsers:

  • Safari 5.0 (6533.16) - Mac
  • Chrome 5.0.375.99 - Mac

It was working before the patch (and still works after the patch) on Firefox 3.6.7 - Mac

q0rban’s picture

Status: Needs work » Needs review
StatusFileSize
new652 bytes

The patch in #1 didn't work for me on Safari 5.0 (6533.16), but the one attached does.

sun’s picture

+++ feedback.js
@@ -47,10 +47,14 @@ Drupal.behaviors.feedbackForm = function (context) {
+    $block.animate({'width':'250px'}, {queue:false,duration:500});

Hard-coding a width into JavaScript isn't very nice for themers. Did anyone try whether the intended effect can also be achieved by toggling a CSS class? That said, I still don't fully understand why we need to animate and why this can't be achieved via CSS only.

Powered by Dreditor.

q0rban’s picture

Status: Needs review » Needs work

I agree, this is probably an underlying CSS issue.

q0rban’s picture

Status: Needs work » Needs review
StatusFileSize
new339 bytes

Ok, attached patch fixes it for me by setting a max-width on the form. Needs testing in other browsers, but worked fine in FFX / Safari for me.

sun’s picture

Issue tags: +Needs manual testing

heh, interesting. Needs to be confirmed by others.

jody lynn’s picture

#21 works for me in Chrome.

ari-meetai’s picture

#21 Does work in Chrome 5.0.375.127

danepowell’s picture

Status: Needs review » Reviewed & tested by the community

I don't like going out of the way to support IE6, but other than that the patch looks good, and fixes the bug for me in Chrome 6.

I think this deserves RTBC status...

geodaniel’s picture

I got this working in Chrome by updating the toggle to add a class, which I can then set a width for in the CSS:

/**
 * Collapse or uncollapse the feedback form block.
 */
Drupal.feedbackFormToggle = function ($block, enable) {
  $block.find('form').slideToggle('medium');
  if (enable) {
    $('#feedback-form-toggle', $block).html('[ + ]');
    $('#block-feedback-form').removeClass('expanded');
  }
  else {
    $('#feedback-form-toggle', $block).html('[ − ]');
    $('#block-feedback-form').addClass('expanded');
  }
};
  #block-feedback-form.expanded {
    width: 250px;
  }

It makes it work in Chrome and doesn't break the others, but it does make the animation look a little less smooth in them.

Kutakizukari’s picture

Subscripting...

R-H’s picture

This patch worked for me.

sun’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tobiberlin’s picture

Status: Closed (fixed) » Needs work

I use the 6.x-2.1 version from 27th January 2010 - and this is still an issue.

sun’s picture

Status: Needs work » Closed (fixed)

It's fixed in the latest 6.x-1.x-dev snapshot.

doublejosh’s picture

PS: Think you mean 6.x-2.x-dev
copy/paste: drush up feedback-6.x-2.x-dev

Still cuts off vertically if your have any extra padding on your buttons.