Under Chrome, Safari, Adobe Air... (not Firefox) the feedback window is half readable which make it is useless...
The patch attached adds jQuery animations to make Feedback window fully readable. Works perfectly under Firefox, Chrome, Safari, etc...
| Comment | File | Size | Author |
|---|---|---|---|
| #21 | feedback-730582-21.patch | 339 bytes | q0rban |
| #18 | feedback-730582-18.patch | 652 bytes | q0rban |
| #15 | feedback-error-safari.jpg | 14.01 KB | socialnicheguru |
| #8 | feedback_display_bug.jpg | 15.48 KB | charos |
| #7 | Screen shot 2010-04-16 at 12.08.06 PM.png | 39.54 KB | jody lynn |
Comments
Comment #1
Michel Poulain commentedUnder Chrome, Safari, Adobe Air... (not Firefox) the feedback window is half readable which make it is useless...
The patch attached adds jQuery animations to make Feedback window fully readable. Works perfectly under Firefox, Chrome, Safari, etc...
Comment #2
sunCould you post a screenshot, please?
Comment #3
dkruglyak commentedI have the same problem with these browsers too.
I also found that Feedback module breaks JavaScript of collapsible fieldsets in Chrome and Firefox (only ones I tested). Not even sure where to start debugging it, just collapsible fieldsets appear dead on all forms and do not expand. Wondering if anyone can reproduce and debug that.
Comment #4
ckreutz commentedHave the same problem with Chrome and Safari. Added a small screenshot attached. The above patch did not help in my case or I did something wrong.
UPDATE: Works fine more me too. Thanks!
Comment #5
webmasterkai commentedPatch works for me. I like the solution.
Comment #6
alexpottPatch works for me too
Comment #7
jody lynnI have this problem with every site I work on using Chrome. The patch didn't solve it on the theme I tested with (Rubik)
Comment #8
charos commentedSame issue with Chrome 5 beta
Comment #9
joostvdl commentedPatch #1 is working
Comment #10
charos commentedCan you please post the browser(s) you tried with the patch? Thanks
Comment #11
Archnemysis commented#1 worked for me in Google Chrome 5.0.375.55 and cuased no problems in FireFox 3.6.3; Internet Explorer 8
Comment #12
Archnemysis commentedI should mention that I had changed my feedback.css to display the pop-up on the top left instead of on the bottom right. To keep from having issues, I needed to change patch #1 on lines 51 and 56 to have the position values reflect left instead of right. Not sure if it is a good idea to hard code in CSS values in the java script, but that may be the only solution.
Comment #13
mrsimonelliott commented#1 worked for me. Tested in:
IE7
IE8
FF3.6.3
Chrome 5.03
safari 3.12
opera 9.52
Comment #14
openmediaforge.org commentedThe patch from #1 fixed the problem. I tested it with:
Firefox 3.6.3
Google Chrome 5.0.375.55
Opera 10.10 build 4742
all on Linux.
Comment #15
socialnicheguru commentedthis doesn't seem to quite work in Safari Version 5.0 (5533.16)
Comment #16
socialnicheguru commentedchanged to reflect the error in #15
Comment #17
scottrouse commentedPatch in #1 corrects the issue on the following browsers:
It was working before the patch (and still works after the patch) on Firefox 3.6.7 - Mac
Comment #18
q0rban commentedThe patch in #1 didn't work for me on Safari 5.0 (6533.16), but the one attached does.
Comment #19
sunHard-coding a width into JavaScript isn't very nice for themers. Did anyone try whether the intended effect can also be achieved by toggling a CSS class? That said, I still don't fully understand why we need to animate and why this can't be achieved via CSS only.
Powered by Dreditor.
Comment #20
q0rban commentedI agree, this is probably an underlying CSS issue.
Comment #21
q0rban commentedOk, attached patch fixes it for me by setting a max-width on the form. Needs testing in other browsers, but worked fine in FFX / Safari for me.
Comment #22
sunheh, interesting. Needs to be confirmed by others.
Comment #23
jody lynn#21 works for me in Chrome.
Comment #24
ari-meetai commented#21 Does work in Chrome 5.0.375.127
Comment #25
danepowell commentedI don't like going out of the way to support IE6, but other than that the patch looks good, and fixes the bug for me in Chrome 6.
I think this deserves RTBC status...
Comment #26
geodaniel commentedI got this working in Chrome by updating the toggle to add a class, which I can then set a width for in the CSS:
It makes it work in Chrome and doesn't break the others, but it does make the animation look a little less smooth in them.
Comment #28
Kutakizukari commentedSubscripting...
Comment #29
R-H commentedThis patch worked for me.
Comment #30
sunThanks for reporting, reviewing, and testing! Committed to all branches.
A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.
Comment #32
tobiberlinI use the 6.x-2.1 version from 27th January 2010 - and this is still an issue.
Comment #33
sunIt's fixed in the latest 6.x-1.x-dev snapshot.
Comment #34
doublejosh commentedPS: Think you mean 6.x-2.x-dev
copy/paste: drush up feedback-6.x-2.x-dev
Still cuts off vertically if your have any extra padding on your buttons.