Closed (fixed)
Project:
Drop Cap, Illuminations, and Title-Casing
Version:
6.x-1.1
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
2 Mar 2010 at 11:13 UTC
Updated:
5 Mar 2010 at 13:09 UTC
Hi,
thanks for the module. I tried it and noticed that it broke my site (D6.15). First, it gave a hook_menu -error. There's been some changes in hook_menu between D5 & D6. Also, hook_nodeapi gave a WSOD when no selectors are set.
I made some changes to the code and got it working. Patch is applied. I wasn't sure what was meant with the $core_sent -variable in hook_nodeapi, as it was just a local variable and really didn't make any sense to me. I removed it.
Patch is made against the latest stable (6.x-1.0).
| Comment | File | Size | Author |
|---|---|---|---|
| dropcap_coder.patch | 4.28 KB | afox |
Comments
Comment #1
lefnire commentedYou know what I don't know what happened in CVS world -- I must have branched/tagged/commited in the wrong order or something, but the changes didn't get committed when I upgraded this module to 6.
Per chance could you try the new 6.x-1.1 & see if it works for you? If that's still a no-go, I'll roll back to 6.x-1.0, apply your patch, and make a new release. Thanks repolainen
Comment #2
afox commentedTested and worked well, except I couldn't get multiple dropcaps working. Tried to put multiple selectors, one per row but it didn't work. I changed the separator from newline to comma and it worked. Didn't spend time on how to get the newline separator working (which is a better alternative IMHO). Otherwise works well.
Thanks